Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Yarn V1 test with NODE_ENV #2262

Merged
merged 8 commits into from
Oct 17, 2023
Merged

Add Yarn V1 test with NODE_ENV #2262

merged 8 commits into from
Oct 17, 2023

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented Oct 16, 2023 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

@omerzi omerzi added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Oct 16, 2023
@omerzi omerzi requested a review from yahavi October 16, 2023 14:22
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 16, 2023
@omerzi omerzi added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request and removed improvement Automatically generated release notes labels Oct 16, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 16, 2023
yahavi
yahavi requested changes Oct 17, 2023
View reviewed changes
xray_test.go Outdated Show resolved Hide resolved
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Oct 17, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 17, 2023
@omerzi omerzi temporarily deployed to frogbot October 17, 2023 09:36 — with GitHub Actions Inactive
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Oct 17, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 17, 2023
@github-actions
Copy link
Contributor

@omerzi omerzi merged commit d2a2597 into jfrog:dev Oct 17, 2023
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerzi @yahavi