Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme updates #21

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Readme updates #21

merged 2 commits into from
Nov 4, 2024

Conversation

luisdalmolin
Copy link
Member

No description provided.

@luisdalmolin luisdalmolin self-assigned this Oct 29, 2024
README.md Outdated
```

The following method would become accessible using TypeScript:

```ts
Status.Active.label() // 'Active'
Status.Inactive.label() // 'Inactive'
Status.Active.color() // 'bg-greed-100'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment should say bg-green-100

### Public Methods

A good majority of the time it is useful to use public methods to return a proper human-readable label or some other functionality on an enum. We've got this covered too. Assuming the following method exists on the above `Status` enum:
A good majority of the time it is useful to use public methods to return a proper human-readable label or some other functionality on an enum. Paragon got this covered too. Assuming the following method exists on the above `Status` enum:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... Paragon has this covered...

Copy link
Member

@brandonferens brandonferens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple grammar updates

@luisdalmolin luisdalmolin merged commit 6ea3fe1 into main Nov 4, 2024
7 checks passed
@luisdalmolin luisdalmolin deleted the update-readme branch November 4, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants