add new id call #19
Closed
add new id call #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codekansas
reviewed
Oct 12, 2024
Comment on lines
+674
to
+691
| for id in motor_ids { | ||
| if id == motor_id { | ||
| let mut pack = CanPack { | ||
| ex_id: ExId { | ||
| id: motor_id, | ||
| data: 0, | ||
| mode: CanComMode::MotorId, | ||
| res: 0, | ||
| }, | ||
| len: 8, | ||
| data: vec![0; 8], | ||
| }; | ||
|
|
||
| pack.ex_id.data = ((new_motor_id as u16) << 8) | (motor_id as u16); | ||
| self.send_command(&pack); | ||
| break; | ||
| } | ||
| }; |
There was a problem hiding this comment.
can't we just get the motor by the index in the dictionary?
| data: vec![0; 8], | ||
| }; | ||
|
|
||
| pack.ex_id.data = ((new_motor_id as u16) << 8) | (motor_id as u16); |
There was a problem hiding this comment.
this seems wrong - shouldn't it just be new_motor_id (not motor_id), also, i think we should be able to do something like new_motor_id.to_le_bytes()
|
deleted upstream code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.