-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config.go: invoke the MaskProxyPasswordWithKey function to hide the e… #20222
base: master
Are you sure you want to change the base?
config.go: invoke the MaskProxyPasswordWithKey function to hide the e… #20222
Conversation
…nvironment variable When the HTTP_PROXY variable is set in the environment, Minikube hides the password when showing the network options, but displays it when showing the (env) variable. The "showVersionInfo" function has been changed to hide the variable's password as well.
The committers listed above are authorized under a signed CLA. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CalobTech The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @CalobTech! |
Hi @CalobTech. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @CalobTech for this PR, do you mind pasting the output of minikube Before/After this PR
(ofc with dummy value for the password)
…nvironment variable
When the HTTP_PROXY variable is set in the environment, Minikube hides the password when showing the network options, but displays it when showing the (env) variable.
The "showVersionInfo" function has been changed to hide the variable's password as well.