Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated Twitter's logo to X #49384

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: updated Twitter's logo to X #49384

wants to merge 1 commit into from

Conversation

aakankshabhende
Copy link

Description

Updated Twitter's logo to "X" in the site's footer.

Issue

Closes: #46405

@aakankshabhende
Updated twitter's logo to X
1135e96 
Signed-off-by: aakankshabhende <aakanksha0407@gmail.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign salaxander for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 10, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1135e96
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6780cdb0a67c430008796696
😎 Deploy Preview https://deploy-preview-49384--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

/area web-development

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Jan 10, 2025
dipesh-rawat
dipesh-rawat reviewed Jan 10, 2025
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated icon appears to not be rendering in the footer of the deploy preview (check here).

@aakankshabhende
Copy link
Author

Yes, font-awesome needs to be updated to v6.4.2 for that. Sending a fix for that

@aakankshabhende aakankshabhende marked this pull request as draft January 10, 2025 09:59
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@reylejano reylejano Awaiting requested review from reylejano

@sftim sftim Awaiting requested review from sftim

Assignees
No one assigned
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

𝕏 (formerly, Twitter) icon not showing in website footer
3 participants
@aakankshabhende @k8s-ci-robot @dipesh-rawat