Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hsmtool] SPX cleanups #25700

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

cfrantz
Copy link
Contributor

@cfrantz cfrantz commented Dec 18, 2024

  1. It is legal for SPX key entities to be missing a PKCS#11 id.
  2. Rename the acorn field to spx, as it represents a generic interface to SPX functions rather than a specific implementation.

It is legal for SPX key entities to be missing a PKCS#11 `id`.

Signed-off-by: Chris Frantz <cfrantz@google.com>
Rename the `acorn` field to `spx`, as it represents a generic interface
to SPX functions rather than a specific implementation.

Signed-off-by: Chris Frantz <cfrantz@google.com>
@cfrantz cfrantz requested a review from a team as a code owner December 18, 2024 18:40
@moidx moidx requested review from jadephilipoom and removed request for a team December 18, 2024 18:41
Copy link
Contributor

@moidx moidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cfrantz cfrantz merged commit 5c91217 into lowRISC:earlgrey_1.0.0 Dec 19, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants