fix: padRight should be used for hex strings representing encoded bytes

lukso-network · Jul 29, 2024 · 9a12476 · 9a12476
1 parent 12ee2e8
commit 9a12476
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/src/components/shared/ContractFunction.vue b/src/components/shared/ContractFunction.vue
@@ -1,7 +1,7 @@
 <script setup lang="ts">
 import { decodeData, MethodType } from '@/helpers/functionUtils'
 import { reactive, computed, watch, onMounted } from 'vue'
-import { toWei, Unit, padLeft, numberToHex } from 'web3-utils'
+import { toWei, Unit, padLeft, padRight, numberToHex } from 'web3-utils'
 import ParamField from './ParamField.vue'
 import useWeb3Connection from '@/compositions/useWeb3Connection'
 import ERC725 from '@erc725/erc725.js'
@@ -179,7 +179,7 @@ const makeBytes = (value: string, type: string) => {
       return padLeft(hex, bytesCount * 2)
     }
     if (/^0x[0-9a-f]*$/i.test(value)) {
-      return padLeft(value, bytesCount * 2)
+      return padRight(value, bytesCount * 2)
     }
     if (/^\w*(:.*,.*)?$/.test(value)) {
       const items = (value || '').split(',')

diff --git a/src/components/shared/ParamField.vue b/src/components/shared/ParamField.vue
@@ -1,6 +1,13 @@
 <script setup lang="ts">
 import { reactive, computed, watch } from 'vue'
-import { toWei, Unit, padLeft, numberToHex, hexToNumber } from 'web3-utils'
+import {
+  toWei,
+  Unit,
+  padLeft,
+  padRight,
+  numberToHex,
+  hexToNumber,
+} from 'web3-utils'
 import ERC725, { ERC725JSONSchema } from '@erc725/erc725.js'
 import LSPSelect from '@/components/shared/LSPSelect.vue'
 import { BN } from 'bn.js'
@@ -377,7 +384,7 @@ const makeBytes32 = (index: number, force = false) => {
       }
     }
     if (/^0x[0-9a-f]*$/i.test(item.value)) {
-      return padLeft(item.value, 64)
+      return padRight(item.value, 64)
     }
     if (/^[0-9]*$/.test(item.value)) {
       return padLeft(item.value, 64)