feat: eth_signTransaction and personal_sign components

[JeneaVranceanu]

https://app.clickup.com/t/86byuf8j1

Added support for eth_signTransaction and personal_sign.

• personal_sign and eth_sign are now one component. The returned value must be the same as for eth_sign.
• eth_signTransaction - visually it's a combination of eth_sendTransaction and eth_sign. This component sends a transaction to sign and allows for:
  • signer address recovery (same as eth_sign component);
  • signature validation through EIP1271.isValidSignature (same as eth_sign component);
  • checking if the signer has SIGN permission (just decided to add);

eth-sign.mov

[richtera]

Curious but should we upgrade the sign with ethereum stuff? I had looked at that before but it seemed to not match signatures somewhere

[JeneaVranceanu]

it seemed to not match signatures somewhere

@richtera If so then we need to update it. I'll open a separate task to double-check that SIWE implementation matches the standard.

[github-actions]

Deployed with Cloudflare Pages ☁️ 🚀 🆗

• URL: https://feat-sign-components.universalprofile-test-dapp.pages.dev
• Specific: https://aa17047b.universalprofile-test-dapp.pages.dev

[JeneaVranceanu]

Sorry for the long waiting. Had more issues with tests.
Now it's fixed and ready to be re-reviewed and potentially merged.

[dzbo]

Sign and Personal Signare very similar, can we merge it into one? Just add another checkbox underSign in with Ethereum`.

[JeneaVranceanu]

Sign and Personal Signare very similar, can we merge it into one? Just add another checkbox underSign in with Ethereum`.

I'll need to re-review this PR but yes, we can merge them into one.

[Hugoo]

I guess this is stale - shall we close this one? @JeneaVranceanu

[JeneaVranceanu]

I guess this is stale - shall we close this one? @JeneaVranceanu

I'll check and let you know.

[richtera]

This looks ok, but it's only logging things?

[franckwei]

@JeneaVranceanu FYI this PR has been opened since last summer, should we merge?

[JeneaVranceanu]

@JeneaVranceanu FYI this PR has been opened since last summer, should we merge?

I'm moving the task to testing.
I think we will merge tomorrow.
It's kind of the lowest priority 😅