-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang Support #84
Clang Support #84
Conversation
Co-authored-by: TheMarpe <martin.peterlin7@gmail.com>
Could this get pushed downstream so depthai-core can use it properly? |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@onthegrid007 sorry, one additional thing - do you mind adding it to CI as well?
(otherwise LGTM) |
I can if you could tell me what the CI is...? |
@onthegrid007 the Continious Integration - there is a .yml workflow file that runs "tests/builds" of the codebase using various platforms/operating systems. |
Yes I can try. Give ma little bit |
Done. |
@onthegrid007 |
It succeeded... |
I mean that clang wasn't used to compile, but it was still MSVC:
Under the windows, clang build |
I'll make a change and see if it fixes it |
Ninja or some other makefile system is required for cmake to execute using clang properly, that has been added and should allow the CI to propagate... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC: @moratom please integrate, thanks
Adds Clang support
Fixes issues:
#80
luxonis/depthai-core#1044