initial no_std support #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure is it fail or just failed to check |
|
It failed due to formating. So it's not a problem. I can fix it. Also, there are some other things I want to add. However, I am currently quite busy, but I have it on my mind. |
marcbone
reviewed
Jun 19, 2021
| @@ -20,6 +20,16 @@ path = "src/lib.rs" | |||
| name = "plot" | |||
| path = "examples/plot.rs" | |||
|
|
|||
| [dependencies] | |||
| [dependencies.num-traits] | |||
There was a problem hiding this comment.
Do you really need this dependency? What is it doing?
There was a problem hiding this comment.
Its for mathematical operations on floats. no_std dont have it.
There was a problem hiding this comment.
AFAIK num_trait is for division/multiplication, and libm is for sqrt
…"std" and invert logic
|
Could you test if this works for you one final time before I release it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.