setup-teslausb: fix terminal detection for upgrade

setup-teslausb's stdin was set to /dev/null on upgrade, which would bypass some of the interactive prompts.
marcone · Oct 31, 2023 · 8668a24 · 8668a24
1 parent eac41ee
commit 8668a24
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/setup/pi/setup-teslausb b/setup/pi/setup-teslausb
@@ -159,7 +159,7 @@ fi
 
 if [ "$REBOOT" = "true" ]
 then
-  if [ -t 0 ]
+  if [ -t 0 ] && [ "${NO_REBOOT_PROMPT:-}" != "1" ]
   then
     setup_progress "please reboot for changes to take effect"
     exit
@@ -498,7 +498,7 @@ function cmd_upgrade {
   fi
   copy_script setup/pi/setup-teslausb /tmp &> /dev/null
   copy_script setup/pi/envsetup.sh /tmp &> /dev/null
-  exec bash -c "/tmp/setup-teslausb upgrade_prepare && /tmp/setup-teslausb && /tmp/setup-teslausb upgrade_finish" < /dev/null
+  exec bash -c "/tmp/setup-teslausb upgrade_prepare && NO_REBOOT_PROMPT=1 /tmp/setup-teslausb && /tmp/setup-teslausb upgrade_finish"
 }
 
 function cmd_upgrade_prepare {
@@ -958,7 +958,7 @@ headless_setup_progress_flash 5
 
 setup_progress "All done."
 
-if [ -t 0 ]
+if [ -t 0 ] && [ "${NO_REBOOT_PROMPT:-}" != "1" ]
 then
   setup_progress '(reboot now for changes to take effect)'
 fi