Suppress UX courtesy reminders on non-interactive shells #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P/Rsync to TeslaUSB
marcone
reviewed
Dec 21, 2023
setup/pi/setup-teslausb
Outdated
| @@ -918,11 +918,13 @@ sed -i '/source \/root\/bin\/setup-teslausb/d' /root/.bashrc | |||
| if ! grep -q TESLAUSB_TIP1 /root/.bashrc | |||
| then | |||
| cat >> /root/.bashrc <<- EOC | |||
| if [ -n "\$PS1" ]; then | |||
There was a problem hiding this comment.
This line and the closing fi below should be tab-indented.
(see man bash for how the <<- redirection operator works)
There was a problem hiding this comment.
Ahh, thank you. I replaced the space indents with tabs, and also improved other indentation after reading the docs.
…X courtesy reminders from non-interactive shells
marcone
reviewed
Dec 23, 2023
setup/pi/setup-teslausb
Outdated
|
|
||
| TESLAUSB_TIP1 | ||
| if [ -n "\$PS1" ] | ||
| then |
There was a problem hiding this comment.
Can you change this back to if [ ...] ; then, like it is below on line 938?
While the TeslaUSB scripts use the if-on-the-next-line style, this if is written to .bashrc, which uses the if-on-the-same-line style.
…-teslausb meant to suppress UX courtesy reminders from non-interactive shells
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having issues SCPing and rsyncing to TeslaUSB from another machine due to the UX courtesy reminders. I found these changes suppress the messages in non-interactive shells, resolving the issue.