Add signal API alerting #805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcone
reviewed
Jan 2, 2024
doc/SetupRSync.md
Outdated
Comment on lines
61
to
65
|
|
||
| # Step 3: Networking | ||
| If you have a firewall between the server and teslausb you will need to allow ports 22 and ICMP. | ||
| Port 22 is used for the rsync service | ||
| ICMP is used to verify the archive is reachable from teslausb |
There was a problem hiding this comment.
This doesn't appear to have anything to do with adding Signal notifications?
(the bit about icmp is also no longer correct)
marcone
reviewed
Jan 4, 2024
There was a problem hiding this comment.
You're still adding a new empty line to this file.
This file shouldn't be part of the PR at all.
marcone
reviewed
Jan 4, 2024
run/send-push-message
Outdated
| function send_signal () { | ||
| log "Sending Signal message." | ||
|
|
||
| curl -X POST -H "Content-Type: application/json" $SIGNAL_URL'/v2/send' \ |
There was a problem hiding this comment.
"$SIGNAL_URL/v2/send" is easier to read and should avoid the shellcheck error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.