Check internet connection using api_endpoint if present in CLIENT_OPTIONS settings #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaistkd
requested review from
daniel-ruiz,
EmilioCarrion,
AdamjGoddard,
jonasae and
a team
as code owners
jBonoraW
approved these changes
Feb 29, 2024
awaistkd
deleted the
check-internet-connection-from-api-endpoint-if-client-options-are-in-settings
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What?
Updated how we check the internet connection. Previously we were using
www.google.comto check the internet connection. Since we added the option to provideapi_endpointvia CLIENT_OPTIONS settings, we want to use the same endpoint to check the internet connection.🤔 Why?
In cases when we are connecting to different endpoint for example (interconnect), we want to check the internet connection using that endpoint.
🔗 Related issue