[VCM]Deprecate the Video Conference Mute utility #36772
Conversation
| displayName: Sign x86 DirectShow VCM | ||
| signingIdentity: ${{ parameters.signingIdentity }} | ||
| inputs: | ||
| FolderPath: 'x86/$(BuildConfiguration)' # Video conf uses x86 and x64. |
There was a problem hiding this comment.
There's one more comment # Video conf uses x86 and x64. in this file, I guess just remove it so we don't have a reference to removed stuff.
There was a problem hiding this comment.
Yeah, that comment is weird... thanks for noticing.
src/gpo/assets/PowerToys.admx
Outdated
There was a problem hiding this comment.
do we need revision update here?
There was a problem hiding this comment.
Indeed. Just pushed.
src/gpo/assets/en-US/PowerToys.adml
Outdated
There was a problem hiding this comment.
Indeed. Just pushed. Thank you for the review!
There was a problem hiding this comment.
@jaimecbernardo, @cinnamon-msft, @DHowett
Don't remove the policy from ADMX. Doing this is a don't.
Reason: The registry value is stil added to the policy file and you can't remove it anymore because of the missing template definition.
Solution: Update supported on value and add "(Depreciated)" to the policy name. (Maybe moving it into a "depreciate policies" folder like done for Google Chrome.)
htcfreek
added
the
Status-Blocked
Summary of the Pull Request
Removes the Video Conference Mute Utility
Removes the Webcam Report Tool from the helper tools, which was used to gather information about webcams.
Adds logic to remove stray registry entries from previous versions of PowerToys, so that VCM gets unlisted. This is done both in the installer and when running PowerToys as administrator (User-scope installers are unable to run the code to remove these registry entries.
PR Checklist
Detailed Description of the Pull Request / Additional comments
For the clean up of previous registry values cleanup code, these are the relevant commits in the PR:
6b51209
7763763
Validation Steps Performed
Built a 0.87.10 installer and tested many upgrade scenarios:
1 - Install 0.87.1, enable VCM, uninstall 0.87.1 and then install 0.87.10 machine-scope installer. Verify that the VCM camera is no longer an option on Teams. (Need to restart Teams for that).
2 - Install 0.87.1 machine-scope, enable VCM, and then upgrade to 0.87.10 through the machine-scope installer. Verify that the VCM camera is no longer an option on Teams. (Need to restart Teams for that).
3 - Install 0.87.1 user-scope, enable VCM, and then upgrade to 0.87.10 through the user-scope installer. Verify that VCM camera is still there. Restart PowerToys as administrator. Verify that the VCM camera is no longer an option on Teams. (Need to restart Teams for that).