Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add single and holy-grail layout component, update site #582

Merged
merged 14 commits into from
Nov 28, 2023

Conversation

wibjorn
Copy link
Contributor

@wibjorn wibjorn commented Nov 16, 2023

Tasks:

Link: preview-582
Layout page link: https://design.learn.microsoft.com/pulls/582/components/layout.html

This pull request adds a new layout component to Atlas and that components first two layouts (of 4 initially planned).

Layouts in this PR are single and holy grail. The simplest and the most complex of those planned.

In order to better test the CSS changes (and to take advantage of the new layout component itself), I retooled the site slightly.

  • applied the holy grail layout and removed some of the one-off site code
  • a mini feature for applying different layouts on the layout documentation page.
  • a mobile menu was added to ensure that on narrow widths we could hide the large menu of navigation links. This feature was done quite hastily, and its approach was that way it is because we've yet to create a modal in Atlas. I would like to revisit it when modal is added to further improve it and remove the fullscreen functionality.
  • as part of the above, a burger component that lives in the site only. Perhaps it can be removed as nav bar moves into Atlas.
  • In order to test the layout-hero container, I added some build logic to extract the H1 and first paragraph from the markdown article and then add them to a hero element. This is done with yaml front matter, and hero: true. I only applied it to the layout page for now.

Testing

  1. Visit preview link above. Visit /components/layout.html in TOC.
  2. Resize screen to narrow. Open new mobile menu.
  3. On the layout component page, try buttons in the "Try" section near the top. Also apply single layout.
  4. Resize screen.
  5. See paired PR.

Contributor checklist

  • Did you update the description of this pull request with a review link and test steps?
  • Did you submit a changeset? Changesets are required for all code changes.
  • Does your pull request add a new page to the documentation site? Add your new page for automated accessibility testing in /integration/tests/accessibility.
  • Does your pull request implement complex UI logic (js/ts)? Consider adding an integration test to test your user flow.

@wibjorn wibjorn requested a review from a team as a code owner November 16, 2023 22:49
Copy link

changeset-bot bot commented Nov 16, 2023

🦋 Changeset detected

Latest commit: 7639071

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@microsoft/atlas-site Minor
@microsoft/atlas-css Minor
@microsoft/parcel-transformer-markdown-html Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wibjorn wibjorn changed the title add single and holy-grail layout component, update site to use holy-g… add single and holy-grail layout component, update site Nov 16, 2023
@wibjorn wibjorn marked this pull request as draft November 16, 2023 22:49
@wibjorn wibjorn marked this pull request as ready for review November 16, 2023 23:14
@bbalentine87
Copy link

@wibjorn If you close the mobile menu with the escape key, the x button gets stuck at the top of the page until you refresh.
image
image

site/src/components/layout.md Outdated Show resolved Hide resolved
site/src/components/layout.md Show resolved Hide resolved
site/src/components/layout.md Outdated Show resolved Hide resolved
@wibjorn wibjorn force-pushed the wbb/layout-single-holy-grail branch from 734cd04 to b012c8a Compare November 17, 2023 19:40
ollips

This comment was marked as outdated.

@wibjorn wibjorn force-pushed the wbb/layout-single-holy-grail branch from 151d76a to 3a8ab9b Compare November 17, 2023 22:08
css/src/components/layout.scss Outdated Show resolved Hide resolved
site/src/scaffold/standard.html Show resolved Hide resolved
css/src/tokens/layout.scss Outdated Show resolved Hide resolved
site/src/tokens/layout.md Outdated Show resolved Hide resolved
@wibjorn wibjorn force-pushed the wbb/layout-single-holy-grail branch from f04e68c to 8949b10 Compare November 27, 2023 22:26
.layout {
display: flex;
flex-direction: column;
// min-inline-size: 100vh;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove this comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed!

@wibjorn wibjorn force-pushed the wbb/layout-single-holy-grail branch from 24310f0 to f82ed9c Compare November 28, 2023 19:26
@wibjorn wibjorn force-pushed the wbb/layout-single-holy-grail branch from e3def69 to 652c401 Compare November 28, 2023 21:25
@wibjorn wibjorn merged commit 5708e1f into main Nov 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants