-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add single and holy-grail layout component, update site #582
Conversation
🦋 Changeset detectedLatest commit: 7639071 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@wibjorn If you close the mobile menu with the escape key, the x button gets stuck at the top of the page until you refresh. |
734cd04
to
b012c8a
Compare
151d76a
to
3a8ab9b
Compare
f04e68c
to
8949b10
Compare
Co-authored-by: Ben Myers <benmyers@microsoft.com>
…rosoft/atlas-design into wbb/layout-single-holy-grail
css/src/components/layout.scss
Outdated
.layout { | ||
display: flex; | ||
flex-direction: column; | ||
// min-inline-size: 100vh; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed!
24310f0
to
f82ed9c
Compare
e3def69
to
652c401
Compare
Tasks:
Link: preview-582
Layout page link: https://design.learn.microsoft.com/pulls/582/components/layout.html
This pull request adds a new layout component to Atlas and that components first two layouts (of 4 initially planned).
Layouts in this PR are single and holy grail. The simplest and the most complex of those planned.
In order to better test the CSS changes (and to take advantage of the new layout component itself), I retooled the site slightly.
hero: true
. I only applied it to the layout page for now.Testing
/components/layout.html
in TOC.Contributor checklist
Does your pull request implement complex UI logic (js/ts)? Consider adding an integration test to test your user flow.