Update padding and width of message component #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3c00eaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
homing1
previously approved these changes
Nov 19, 2024
wibjorn
previously approved these changes
Dec 6, 2024
wibjorn
reviewed
Dec 6, 2024
css/src/components/message.scss
Outdated
| } | ||
|
|
||
| &.message-sm.message-sender { | ||
| width: auto; |
There was a problem hiding this comment.
I think width:auto may not be the expected behavior here for all chats, and why is it scoped to message-sm?
There was a problem hiding this comment.
Why do we need it baked in here? what about using width-auto?
wibjorn
reviewed
Dec 6, 2024
site/src/patterns/chat.md
Outdated
| @@ -52,6 +52,43 @@ For a copilot-friendly input, with a series of buttons placed within the visual | |||
| </div> | |||
| ``` | |||
|
|
|||
| ## Copilot-like chat messages | |||
|
|
|||
| To mimic a copilot chat experience, apply `message-sm` and `message-sender` to automatically fit to the width of the sender's message. For the AI responses (`message-sm`), the message will take up the full width. | |||
There was a problem hiding this comment.
The classes don't seem to match the behaviors here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link: preview
Update the width and the padding of the message component to match fluent 2. Changes only affect
message-sm, so the padding changes do not apply to the regular sizedmessage.Sources:
Fluent AI storybook: https://ai.fluentui.dev/?path=/docs/components-copilotchat-v2-usermessagev2--docs
Yonder's specs: https://www.figma.com/design/3TjpAzAIwxnPv4zpA1D2Iq/AI-Assistant-on-Microsoft-Learn?node-id=826-78921&t=r4kQ5xoqPCMfvMOE-1
Changes:
Contributor checklist