Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update danger color #732

Merged
merged 9 commits into from
Dec 5, 2024
Merged

Update danger color #732

merged 9 commits into from
Dec 5, 2024

Conversation

homing1
Copy link
Contributor

@homing1 homing1 commented Dec 2, 2024

Link: preview

This PR updates the danger semantic color to match Fluent 2 on light theme.

Testing

  1. Visit the following pages to review the affected colors, should still work on dark and high contrast theme. Compare with https://react.fluentui.dev/ . Also compare with https://design.learn.microsoft.com/ for the current Atlas colors.

Additional information

[Optional]

Contributor checklist

  • Did you update the description of this pull request with a review link and test steps?
  • Did you submit a changeset? Changesets are required for all code changes.
  • Does your pull request implement complex UI logic (js/ts)? Consider adding an integration test to test your user flow.
  • Does your pull request add a new page to the documentation site? Add your new page for automated accessibility testing in /integration/tests/accessibility.
  • Does your pull request change any transforms? Did you test they work on right to left?

Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: db6e87f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@microsoft/atlas-css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@homing1 homing1 changed the title Ming/update danger Update danger color Dec 2, 2024
@homing1 homing1 marked this pull request as ready for review December 2, 2024 20:31
@homing1 homing1 requested a review from a team as a code owner December 2, 2024 20:31
@homing1 homing1 mentioned this pull request Dec 2, 2024
5 tasks
wibjorn
wibjorn previously approved these changes Dec 3, 2024
@homing1 homing1 merged commit 9460d2f into main Dec 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants