-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update warning color #733
Update warning color #733
Conversation
🦋 Changeset detectedLatest commit: fbaebc7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0a7b40f
to
507d508
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow up I'd like to chat how we can improve buttons style. Approving for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resetting my vote, I think I missed something. Will follow up
Link: preview
This PR updates the warning color to match Fluent on light theme. Fluent uses orange colors for warning, but they also have yellow colors. Therefore, this PR adds both a yellow and orange palette. Also updating warning colors for dark and high contrast theme to make everything orange for consistency.
Testing
notification-primary
tonotification-warning
.Additional information
[Optional]
Contributor checklist