-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Banner and Notification components update #735
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 8228df9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
css/src/components/notification.scss
Outdated
@@ -1,31 +1,34 @@ | |||
$notification-background: $secondary-background !default; | |||
$notification-padding: $spacer-5 !default; | |||
$notification-padding-vertical: 0.5em !default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
css/src/components/banner.scss
Outdated
@@ -1,31 +1,57 @@ | |||
$banner-background: $info-background !default; | |||
$banner-padding: $spacer-5 !default; | |||
// $banner-background: $info-background !default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove?
Link: preview
Component:
Pattern:
Updating banner and notification components to match Fluent and creating pattern pages for them to showcase a few non-standard use cases.
Key points:
Testing
Contributor checklist