Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Banner and Notification components update #735

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ollips
Copy link
Contributor

@ollips ollips commented Jan 9, 2025

Link: preview

Component:

Pattern:

Updating banner and notification components to match Fluent and creating pattern pages for them to showcase a few non-standard use cases.

Key points:

  • Banner has semantic colors.
  • Banner has restricted content width.
  • Both banner and notification content's font size is 14px, action buttons are 12px. Fluent has content 12px as well but it looks too small next to the default 16px used everywhere on Learn.
  • Both components can contain action buttons. pattern pages were created to showcase how it can be achieved in conjunction with other atomics.

image

Testing

  1. Visit all links attached above.
  2. Try different sizes, try to modify text within component to make it longer and ensure it wraps correctly.
  3. Ensure it matches the Fluent's "Message bar" component

Contributor checklist

  • Did you update the description of this pull request with a review link and test steps?
  • Did you submit a changeset? Changesets are required for all code changes.
  • Does your pull request implement complex UI logic (js/ts)? Consider adding an integration test to test your user flow.
  • Does your pull request add a new page to the documentation site? Add your new page for automated accessibility testing in /integration/tests/accessibility.
  • Does your pull request change any transforms? Did you test they work on right to left?

@ollips ollips requested a review from a team as a code owner January 9, 2025 23:44
@ollips ollips changed the title Banner and Notification components update [wip] Banner and Notification components update Jan 9, 2025
Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 8228df9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@microsoft/atlas-site Minor
@microsoft/atlas-css Major
@microsoft/parcel-transformer-markdown-html Patch
atlas-design-system-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -1,31 +1,34 @@
$notification-background: $secondary-background !default;
$notification-padding: $spacer-5 !default;
$notification-padding-vertical: 0.5em !default;
Copy link
Contributor

@homing1 homing1 Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there can be more vertical and horizontal padding, same for banner.

image

@@ -1,31 +1,57 @@
$banner-background: $info-background !default;
$banner-padding: $spacer-5 !default;
// $banner-background: $info-background !default;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants