Add credential support to AzureBlobCacheStorage
#510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altinokdarici
force-pushed
the
user/altinokd/pass-creds
branch
from
41b3411 to
ab30f15
Compare
ecraig12345
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Currently, passing connection string with a SAS token is the only way to configure 'Azure Blob'. However, I need to support interactive login in cloudpack.
The workaround is to use InteractiveBrowserClient and generate a SAS token out of it. Although this method works fine, there are lots of limitations such as there is no way use refresh token or persistence option.
Fix: Adding ability to pass Credential object. This way, I can set up InteractiveBrowserClient and take full advantage of azure/identity