Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: Helix.Helix version 25.01 #208096

Merged
merged 2 commits into from
Jan 10, 2025
Merged

New version: Helix.Helix version 25.01 #208096

merged 2 commits into from
Jan 10, 2025
+60 −0

Conversation

norquisd
Copy link
Contributor

@norquisd norquisd commented Jan 7, 2025 •
edited by microsoft-github-policy-service bot
Loading

Pull request has been created with komac v2.8.0 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@norquisd
Copy link
Contributor Author

norquisd commented Jan 7, 2025

@microsoft-github-policy-service agree

@kris6673
Copy link
Contributor

kris6673 commented Jan 7, 2025

Resolves: #207847

@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Jan 7, 2025
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\hx.exe returned exit code: -1073741515

Automated error analysis suggests -1073741515 may mean STATUS_DLL_NOT_FOUND - possibly due to a dependency on Microsoft.VCRedist.2015+.x64 (or .x86).

(Automated response - build 937.)

stephengillie
stephengillie requested changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@stephengillie stephengillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual Validation ended with:
image

manifests/h/Helix/Helix/25.01/Helix.Helix.installer.yaml Show resolved Hide resolved
@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jan 8, 2025
@norquisd @stephengillie
Update manifests/h/Helix/Helix/25.01/Helix.Helix.installer.yaml
4ce4187 
Co-authored-by: Stephen Gillie <114952565+stephengillie@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Validation-Executable-Error Changes-Requested Changes Requested New-Manifest labels Jan 8, 2025
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@norquisd norquisd requested a review from stephengillie January 8, 2025 20:21
@norquisd
Copy link
Contributor Author

norquisd commented Jan 8, 2025

Sorry if re-requesting a review wasn't the right move @stephengillie, but I made your change and I think the azure pipeline is running again

@wingetbot
Copy link
Collaborator

/AzurePipelines run

1 similar comment
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 9, 2025
@stephengillie
Copy link
Collaborator

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 9, 2025
@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 10, 2025
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

norquisd,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 63e8f4d into microsoft:master Jan 10, 2025
2 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@norquisd @wingetbot @kris6673 @stephengillie