Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Attachment and Complex Character Positioning #19

Merged
merged 15 commits into from
Aug 31, 2022
Merged

Add Attachment and Complex Character Positioning #19

merged 15 commits into from
Aug 31, 2022

Conversation

mjakeman
Copy link
Owner

@mjakeman mjakeman commented Aug 24, 2022

  • Adds 'attachment' - this is a term borrowed from webkit to describe the process of attaching semantic model nodes to view-specific layout nodes.
  • Implements home and end line traversal according to Formalise character positioning #17
  • Implements mouse-based picking for determining index under mouse position

TODO

  • Add up/down movement
  • Add cursor selection
  • Add unit tests for home/end Deferred until traversal is separated from view
  • Issues:
    • Fix issue with splitting then entering at the start of the paragraph
    • Cannot select final index in paragraph with mouse Pango issue, deferred until resolution on use of paragraph break characters
  • Clean up:
    • Rework cursor drawing to only reallocate when necessary
    • Use fuzzy cursor picking (i.e. choose nearest when no exact match is found)
    • Up/down within paragraphs

@mjakeman mjakeman enabled auto-merge August 31, 2022 17:32
@mjakeman mjakeman merged commit 3e2125a into master Aug 31, 2022
@mjakeman mjakeman deleted the attach branch August 31, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant