Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Incorrect handling of JSON properties #180

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Bugfix: Incorrect handling of JSON properties #180

merged 1 commit into from
Dec 10, 2024

Conversation

paulsaxe
Copy link
Collaborator

  • Any properties that were not a scalar had an issue when being transformed to and from JSON. This is now fixed.
  • Truncated values with known units reasonablt so that they are more readable in tables. For example, 1.23400000001 kJ/mol is now 1.234 kJ/mol.

* Any properties that were not a scalar had an issue when being transformed to and
  from JSON. This is now fixed.
* Truncated values with known units reasonablt so that they are more readable in
  tables. For example, 1.23400000001 kJ/mol is now 1.234 kJ/mol.
@paulsaxe paulsaxe added the bug Something isn't working label Dec 10, 2024
@paulsaxe paulsaxe requested a review from seamm December 10, 2024 22:19
Copy link
Contributor

@seamm seamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seamm seamm merged commit 933d40d into main Dec 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants