Critical code review PR - Last sprint handover checklist of 0.11.0 release #228

vishwa-vyom · 2025-01-08T05:10:18Z

This PR is created just to add the review comments as part of the critical code review task of last sprint handover checklist for release of 0.10.0 version.

** THIS PR SHOULD NOT BE MERGED **

Signed-off-by: techno-376 <rakshitham38@gmail.com>

Signed-off-by: Rakshitha650 <76676196+Rakshitha650@users.noreply.github.com>

[MOSIP-34820]removed ExtraEnvVrs as its not required

Signed-off-by: Mohan E <mohanraj1715@gmail.com>

[DSD-6004] Updated browserstack-web.yml to push artifacts to s3 bucket.

…share Signed-off-by: shubham-technoforte <shubham.gawali@technoforte.co.in>

Signed-off-by: shubham_G <88794020+shubham17998@users.noreply.github.com>

[MOSIP-34934] Updated datashare helm to work as default and inji-datashare

…share Signed-off-by: shubham_G <88794020+shubham17998@users.noreply.github.com>

[MOSIP-34934] Updated datashare helm to work as default and inji-datashare

[INJIWEB-724] : update error message for invalid client and redirect for OVP flow

Signed-off-by: Anup Nehe <anup.nehe@technoforte.co.in>

MOSIP-35488 fixed inji ui automation

Signed-off-by: Anup Nehe <anup.nehe@technoforte.co.in>

…ng (#134) * [INJIWEB-268] : vc verification with error handling before downloading Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> * [INJIWEB-268] : adding literal support for verification error handling Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> * [INJIWEB-268] : adding literal support for verification error handling Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> * [INJIWEB-268] : adding loggers for debugging Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> * [INJIWEB-268] : updated the error handling Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> * [INJIWEB-268] : updated the error handling Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> * [INJIWEB-424] : readd removed method impl Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> --------- Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com>

Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com>

Signed-off-by: Anup Nehe <anup.nehe@technoforte.co.in>

* [INJIWEB-511]: rebrand the Inji Web home page Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> * [INJIWEB-511]: Translated Literals & Develop Help DropDown Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-511]: Create HelpDropdown Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-511]: Added Toggles & Fix Tests Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-511]: Fix Mobile View Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-511]: Fix Favicon Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-511]: inji web gradiend icons fix Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> * [INJIWEB-511]: Fixed Feature Item height & margin Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-511]: Fix Feature Item Height Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-511]: inji web gradiend icons fix and updated the button wrappers usage Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> * [INJIWEB-511]: update snapshots and icon background Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> * [INJIWEB-511]:Fix interchanging of arrows in mobile view for different languages Signed-off-by: SAIRAM GIRIRAO <sairam.girirao@infosys.com> * [INJIWEB-511]:Fix arrow Interchanging for Arabic Language in Feature Items Signed-off-by: SAIRAM GIRIRAO <sairam.girirao@infosys.com> * Update package.json Signed-off-by: Sairam Girirao <105053210+Sairam-g9162@users.noreply.github.com> * [INJIWEB-511]:Added Test Ids for the new components Signed-off-by: SAIRAM GIRIRAO <sairam.girirao@infosys.com> * [INJIWEB-1025] : coming soon toast for quick tip Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> * [INJIWEB-1025] : add new session modificaiton Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> * [INJIWEB-1025] : add new session modificaiton Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> * [INJIWEB-511]: Add Gradient to Icon Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-511]: Add Gradient to Icon Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-511]: Added TestId Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-511]: Removed Line Pattern Assets Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-511]:Added background img for Homebanner Signed-off-by: SAIRAM GIRIRAO <sairam.girirao@infosys.com> * Add Home Banner Image Signed-off-by: Sairam Girirao <105053210+Sairam-g9162@users.noreply.github.com> * [INJIWEB-511]: update preview images Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> * [INJIWEB-511]: update the data-testids Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> --------- Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> Signed-off-by: SAIRAM GIRIRAO <sairam.girirao@infosys.com> Signed-off-by: Sairam Girirao <105053210+Sairam-g9162@users.noreply.github.com> Signed-off-by: Vijay Kumar S <94220135+vijay151096@users.noreply.github.com> Co-authored-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> Co-authored-by: SAIRAM GIRIRAO <sairam.girirao@infosys.com> Co-authored-by: Sairam Girirao <105053210+Sairam-g9162@users.noreply.github.com>

Signed-off-by: SAIRAM GIRIRAO <sairam.girirao@infosys.com>

* [INJIWEB-1046]: Web Change to Wallet in FAQ Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-1046]: Fix Web to Wallet Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-1046]: Fix Indent & Added Errors in kn.json Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> --------- Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com>

* [INJIWEB-1064]: Fix Title Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-1064]: Fix Title Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> --------- Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com>

… k8s (#187) * [MOSIP-37139] Docker file will run with non-root user in locally as well as k8s Signed-off-by: bhumi46 <thisisbn46@gmail.com> * [MOSIP-37139] Docker file will run with non-root user in locally as well as k8s Signed-off-by: bhumi46 <thisisbn46@gmail.com> * [MOSIP-37139] Docker file will run with non-root user in locally as well as k8s Signed-off-by: bhumi46 <thisisbn46@gmail.com> * [MOSIP-37139] updated stable version for base images and updated documentation for docker run Signed-off-by: bhumi46 <thisisbn46@gmail.com> * [MOSIP-37139] updated stable version for base images and updated documentation for docker run Signed-off-by: bhumi46 <thisisbn46@gmail.com> * [MOSIP-37139] fixed security vulnerabiity,now container will run as non root-user Signed-off-by: bhumi46 <thisisbn46@gmail.com> --------- Signed-off-by: bhumi46 <thisisbn46@gmail.com>

…it dynamically (#189) * [MOSIP-37139] Docker file will run with non-root user in locally as well as k8s Signed-off-by: bhumi46 <thisisbn46@gmail.com> * [MOSIP-37139] Docker file will run with non-root user in locally as well as k8s Signed-off-by: bhumi46 <thisisbn46@gmail.com> * [MOSIP-37139] Docker file will run with non-root user in locally as well as k8s Signed-off-by: bhumi46 <thisisbn46@gmail.com> * [MOSIP-37139] updated stable version for base images and updated documentation for docker run Signed-off-by: bhumi46 <thisisbn46@gmail.com> * [MOSIP-37139] updated stable version for base images and updated documentation for docker run Signed-off-by: bhumi46 <thisisbn46@gmail.com> * [MOSIP-37139] fixed security vulnerabiity,now container will run as non root-user Signed-off-by: bhumi46 <thisisbn46@gmail.com> * [DSD-6579] added mimoto host in values.yaml and install.sh to update it dynamically Signed-off-by: bhumi46 <thisisbn46@gmail.com> --------- Signed-off-by: bhumi46 <thisisbn46@gmail.com>

* [INJIWEB-1064]: Fix Title Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-1064]: Fix Title Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-XXX]: Fix Radio Button Toast Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-XYZ]: Fixed Radio Button Toast Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-XYZ]: Made Event Inline Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> --------- Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com>

* [INJIWEB-1076]: Added Portuguese(Brazilian) Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> * [INJIWEB-1076]: Changed pt_BR to pt Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com> --------- Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com>

Signed-off-by: SAIRAM GIRIRAO <sairam.girirao@infosys.com>

…iable credential (#193) * [INJIWEB-990]: handle vc verification exceptions Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> * [INJIWEB-990]: locale addition for exception in vc verification Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com> --------- Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com>

Signed-off-by: Anup Nehe <anup.nehe@technoforte.co.in>

Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com>

[INJIWEB-1025]: update the readme and compose for docker

Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com>

Signed-off-by: bhumi46 <thisisbn46@gmail.com>

[DSD-6685] reverted changes as it affecting older images

Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>

* [INJIWEB-1213] Fixed docker compose to have one nginx Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> * [INJIWEB-1213] Fixed typo error in configmap file Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> --------- Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>

* [INJIWEB-1213] Fixed docker compose to have one nginx Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> * [INJIWEB-1213] Fixed typo error in configmap file Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> * [INJIWEB-1213] Updated readme file and the mimoto image to 0.15 Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> * [INJIWEB-1213] Removed platform from the dockerfile Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> --------- Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>

* [INJIWEB-1213] Fixed docker compose to have one nginx Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> * [INJIWEB-1213] Fixed typo error in configmap file Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> * [INJIWEB-1213] Updated readme file and the mimoto image to 0.15 Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> * [INJIWEB-1213] Removed platform from the dockerfile Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> * [INJIWEB-1202] Fixed credential template issue Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com> --------- Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>

Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>

vishwa-vyom · 2025-01-08T11:01:49Z

inji-web-proxy/Dockerfile

@@ -0,0 +1,21 @@
+# Dockerfile


Do we still need this inji-web-proxy folder ?

we have to remove this

done please review PR https://github.com/mosip/inji-web/pull/231/files

vishwa-vyom · 2025-01-08T11:04:15Z

docker-compose/config/mimoto-issuers-config.json

+      ],
+      "client_id": "esignet-sunbird-partner",
+      "redirect_uri": "io.mosip.residentapp.inji://oauthredirect",
+      "token_endpoint": "https://api.dev1.mosip.net/v1/mimoto/get-token/StayProtected",


Why are few pointing to collab and few to dev1, can we not keep everything to collab for docker compose ?

this token endpoint should be http://localhost:8099/v1/mimoto/get-token/StayProtected

will get changed after datashare PR approval

vishwa-vyom · 2025-01-08T11:05:42Z

inji-web/nginx.conf

    }


+    # Proxy API requests to mimoto-service
+    location /v1/mimoto/ {
+        proxy_pass http://mimoto-service:8099/v1/mimoto/;


hardcoding here will it not cause issues ? Since mimoto can also run on a different namespace in the env.
Was it deployed in dev1 env after this change and tested ?

agree Vishwa but this is how it is being configured for all other services too.
After deployment, we manually update this config based on service and namespace name

vishwa-vyom · 2025-01-08T11:07:54Z

docker-compose/README.md

+
+## What is in the docker-compose folder?
+
+1. certs folder holds the p12 file which is being created as part of OIDC client onboarding.


certs folder need to be created manually, document should also convey the same.

It's covered in how to run section https://github.com/mosip/inji-web/pull/228/files#diff-dfabd14427afb3bb64fcec883a6c762ccb9c14427de46b8ff5727a0b753153c4R30

swatigoel · 2025-01-08T17:34:34Z

docker-compose/README.md

+
+## What is in the docker-compose folder?
+
+1. certs folder holds the p12 file which is being created as part of OIDC client onboarding.


It's covered in how to run section https://github.com/mosip/inji-web/pull/228/files#diff-dfabd14427afb3bb64fcec883a6c762ccb9c14427de46b8ff5727a0b753153c4R30

swatigoel · 2025-01-08T17:35:35Z

docker-compose/README.md

+4. Start the data share services and update data share host references in mimoto-default.properties. data share service helm is available in the [Inji Web Helm](https://github.com/mosip/inji-web/tree/release-0.10.x/helm/inji-web)
+
+5. Create certs folder in the same directory and create OIDC client. Add key in oidckeystore.p12 and copy this file under certs folder.
+Refer [here](https://docs.mosip.io/inji/inji-mobile-wallet/customization-overview/credential_providers) to create client


let's update document link with new domain https://docs.inji.io/inji-wallet/inji-mobile/customization-overview/credential_providers#onboarding-mimoto-as-oidc-client-for-a-new-issuer

swatigoel · 2025-01-08T17:37:34Z

docker-compose/config/mimoto-default.properties

+#timeout for vc download api via openid4vci flow in milliseconds
+mosip.inji.openId4VCIDownloadVCTimeout=30000
+# inji documentation url
+mosip.inji.aboutInjiUrl=https://docs.mosip.io/inji/inji-mobile-wallet/overview


let's update this document link https://docs.inji.io/inji-wallet/inji-mobile

Done in PR (https://github.com/mosip/inji-web/pull/231/files#diff-b0381158d7131fb22a2fb9f3b7f65d875ed34d3a4262daa14ad098e744f29e7c)

swatigoel · 2025-01-08T17:38:39Z

docker-compose/config/mimoto-default.properties

+#DataShare Config
+mosip.data.share.url=https://datashare-inji.collab.mosip.net
+mosip.data.share.create.url=https://datashare-inji.collab.mosip.net/v1/datashare/create/static-policyid/static-subscriberid
+mosip.data.share.create.retry.count=3
+mosip.data.share.get.url.pattern=https://datashare-inji.collab.mosip.net/v1/datashare/get/static-policyid/static-subscriberid/*


this datashare reference will be replaced by local datashare instance

swatigoel · 2025-01-08T17:42:21Z

docker-compose/config/mimoto-issuers-config.json

+      ],
+      "client_id": "XusU7P1y10lMr9NA1qnrny_fqynODwV4SCvWPP8cfdY",
+      "redirect_uri": "io.mosip.residentapp.inji://oauthredirect",
+      "token_endpoint": "https://api.collab.mosip.net/v1/mimoto/get-token/Mosip",


this token endpoint should be http://localhost:8099/v1/mimoto/get-token/Mosip

will get change with datashare PR

swatigoel · 2025-01-08T18:19:09Z

inji-web/src/__tests__/components/Common/SuccessSheildIcon.test.tsx

+describe("Testing the Functionality of SuccessSheildIcon" ,() =>{
+    test('Check the icon color of SuccessSheildIcon component', () => {
+        renderWithProvider(<SuccessSheildIcon />);
+        expect(screen.getByTestId("DownloadResult-Success-ShieldIcon")).toHaveAttribute('color', 'var(--iw-color-shieldSuccessIcon)');


this assertion would have been covered in snapshot test. It's there in snapshot https://github.com/mosip/inji-web/pull/228/files#diff-f13b971bef5c4929daae801cd41d36cd490a13b8296ff3d25de6b84e2da330fbR12

swatigoel · 2025-01-08T18:24:05Z

inji-web/src/__tests__/components/DataShare/CustomTimes/CustomExpiryTimesContent.test.tsx

+    })
+});
+describe("Testing the  Functionality of custom expiry content",()=>{
+    test("Check the Time Range Metrics", ()=>{


@this test looks redundant as snapshot is also doing the same thing https://github.com/mosip/inji-web/pull/228/files#diff-6e304fc143ae8b1884b77cc7bfffe75787edc1919a4d12d809e89209ace4b51bR65-R70

swatigoel · 2025-01-08T18:28:02Z

inji-web/src/__tests__/components/DataShare/CustomTimes/CustomExpiryTimesContent.test.tsx

+        expect(valueDiv).toHaveValue(expiryTime + "");
+        fireEvent.click(increaseValueButton);
+        expect(expiryMockFn).toHaveBeenCalledTimes(1);
+        expect(expiryMockFn).toHaveBeenCalledWith(expiryTime + 1);


This test would have been completed if we would have clicked on Proceed button after increasing the expiry and confirmed the count.

As discussed with Swati this test case is used to check if the expiryMockFn is called with increased expiry count (current count + 1) or not when user clicks on up arrow (simulating it here by firing the click event on up arrow). So we don't click on any proceed button here. But the test case to check whether the new value is getting rendered in the validity model or not is not added so i will add it.

swatigoel · 2025-01-08T18:28:17Z

inji-web/src/__tests__/components/DataShare/CustomTimes/CustomExpiryTimesContent.test.tsx

+        expect(valueDiv).toHaveValue(expiryTime + "");
+        fireEvent.click(increaseValueButton);
+        expect(expiryMockFn).toHaveBeenCalledTimes(1);
+        expect(expiryMockFn).toHaveBeenCalledWith(expiryTime -1);


This test would have been completed if we would have clicked on Proceed button after decreasing the expiry and confirmed the count.

As discussed with Swati this test case is used to check if the expiryMockFn is called with decreased expiry count (current count - 1) or not when user clicks on down arrow (simulating it here by firing the click event on down arrow element). So we don't click on any proceed button here. But the test case to check whether the new value is getting rendered in validity model or not is not added so i will add it.

swatigoel · 2025-01-08T18:28:41Z

inji-web/src/__tests__/components/DataShare/CustomTimes/CustomExpiryTimesHeader.test.tsx

+
+});
+describe("Testing the functionality of custom expiry Header",()=>{
+    test("Check to Have the content", ()=>{


This test is redundant as covered in snapshot

…r minor comments (#231) Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

…on't change unless we change it in source code and use snapshot tests to track these changes Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

…pose and update docs (#230) Signed-off-by: Abhishek Paul <paul.apaul.abhishek.ap@gmail.com>

…omExpiryTimesHeader test file Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

…ty count is updated in the UI or not when it is changed it with the custom validity option Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

[Injiweb 1359] fix failing tests and remove the redundant tests

Rakshitha650 and others added 30 commits August 7, 2024 14:56

[MOSIP-34820]removed ExtraEnvVrs as its not required

cf839ba

Signed-off-by: techno-376 <rakshitham38@gmail.com>

Update values.yaml

4f795df

Signed-off-by: Rakshitha650 <76676196+Rakshitha650@users.noreply.github.com>

Merge pull request #120 from Rakshitha650/develop

e1644a6

[MOSIP-34820]removed ExtraEnvVrs as its not required

Update browserstack-web.yml

ec681ea

Signed-off-by: Mohan E <mohanraj1715@gmail.com>

Update browserstack-web.yml

eb331ac

Signed-off-by: Mohan E <mohanraj1715@gmail.com>

Update browserstack-web.yml

5d70958

Signed-off-by: Mohan E <mohanraj1715@gmail.com>

Update browserstack-web.yml

c9cf587

Signed-off-by: Mohan E <mohanraj1715@gmail.com>

Update browserstack-web.yml

c41a347

Signed-off-by: Mohan E <mohanraj1715@gmail.com>

Update browserstack-web.yml

fe74d9d

Signed-off-by: Mohan E <mohanraj1715@gmail.com>

[DSD-6004] Updated browserstack-web.yml to push artifacts to s3 bucket.

7f1534d

Signed-off-by: Mohan E <mohanraj1715@gmail.com>

[DSD-6004] Updated browserstack-web.yml

ba8c81d

Signed-off-by: Mohan E <mohanraj1715@gmail.com>

[DSD-6004] Updated browserstack-web.yml

9fee6fe

Signed-off-by: Mohan E <mohanraj1715@gmail.com>

[DSD-6004] Updated browserstack-web.yml

2c6017e

Signed-off-by: Mohan E <mohanraj1715@gmail.com>

[DSD-6004] Updated browserstack-web.yml

bce6cc6

Signed-off-by: Mohan E <mohanraj1715@gmail.com>

Merge pull request #123 from Mohanraj209/develop

e40d67d

[DSD-6004] Updated browserstack-web.yml to push artifacts to s3 bucket.

[MOSIP-34934] Updated datashare helm to work as default and inji-data…

b2b026c

…share Signed-off-by: shubham-technoforte <shubham.gawali@technoforte.co.in>

[MOSIP-34934] Updated datashare helm to work as default and inji-data…

78baf7b

…share Signed-off-by: shubham-technoforte <shubham.gawali@technoforte.co.in>

[MOSIP-34934] Updated install.sh

b4fb01e

Signed-off-by: shubham_G <88794020+shubham17998@users.noreply.github.com>

Merge pull request #125 from shubham17998/develop

ee8be58

[MOSIP-34934] Updated datashare helm to work as default and inji-datashare

[MOSIP-34934] Updated datashare helm to work as default and inji-data…

414b9a1

…share Signed-off-by: shubham_G <88794020+shubham17998@users.noreply.github.com>

Merge pull request #128 from shubham17998/develop

6011e52

[MOSIP-34934] Updated datashare helm to work as default and inji-datashare

Merge pull request #131 from tw-mosip/release-0.10.x

38e708f

[INJIWEB-724] : update error message for invalid client and redirect for OVP flow

MOSIP-35488

a8d4282

Signed-off-by: Anup Nehe <anup.nehe@technoforte.co.in>

reslove cinflict

ef3be90

Signed-off-by: Anup Nehe <anup.nehe@technoforte.co.in>

Merge pull request #132 from anup-nehe/develop

a0e22bb

MOSIP-35488 fixed inji ui automation

INJIWEB-746

1165cbf

Signed-off-by: Anup Nehe <anup.nehe@technoforte.co.in>

Merge remote-tracking branch 'upstream/develop' into develop

151496f

[INJIWEB-268] : handle new UI enhancement.

76dceb2

Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com>

INJIWEB-746 (#133)

f3e5a2b

Signed-off-by: Anup Nehe <anup.nehe@technoforte.co.in>

vijay151096 and others added 21 commits November 5, 2024 11:49

[INJIWEB-511]:Fix overlapping of static image in homepage (#185)

6808d67

Signed-off-by: SAIRAM GIRIRAO <sairam.girirao@infosys.com>

[INJIWEB-1066]:Fix Spacing issue in Landing page (#191)

4472985

Signed-off-by: SAIRAM GIRIRAO <sairam.girirao@infosys.com>

INJIWEB-951 (#196)

78f2ade

Signed-off-by: Anup Nehe <anup.nehe@technoforte.co.in>

[INJIWEB-1025]: update the readme and compose for docker

249c041

Signed-off-by: Vijay <94220135+vijay151096@users.noreply.github.com>

Merge pull request #198 from tw-mosip/release-0.11.x

9583a6a

[INJIWEB-1025]: update the readme and compose for docker

[INJIWEB-1138]: Fixed With Ease in Release Branch (#200)

20ebfc0

Signed-off-by: Kamlesh Singh Bisht <kamlesh.bisht@infosys.com>

[DSD-6685] reverted changes as it affecting older images

6f74a2e

Signed-off-by: bhumi46 <thisisbn46@gmail.com>

Merge pull request #204 from bhumi46/release-0.11.x

c744bad

[DSD-6685] reverted changes as it affecting older images

[INJIWEB-1202] Updated nginx header size for bad gateway error (#217)

74a3782

Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>

[INJIWEB-1349] Fixed urls to point to local injiweb and mimoto (#227)

edbeb28

Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>

vishwa-vyom commented Jan 8, 2025

View reviewed changes

swatigoel reviewed Jan 8, 2025

View reviewed changes

Gurpreet41082 and others added 7 commits January 9, 2025 15:10

[INJIWEB-1359] Fixed review comment to remove inji-web-proxy and othe…

ea6a68b

…r minor comments (#231) Signed-off-by: Gurpreet41082 <gurpreet.kaur@thoughtworks.com>

[INJIWEB-1359] fix failing test cases

aafaac4

Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

[INJIWEB-1359] remove redundant test cases for static content which w…

3c1586e

…on't change unless we change it in source code and use snapshot tests to track these changes Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

[INJIMOB-1349] add data-share and minio service as part of docker com…

7215cd3

…pose and update docs (#230) Signed-off-by: Abhishek Paul <paul.apaul.abhishek.ap@gmail.com>

[INJIWEB-1359] remove redundant test cases for static content in Cust…

0deb87a

…omExpiryTimesHeader test file Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

[INJIWEB-1359] add test case to validate if the new data share validi…

0db0bbf

…ty count is updated in the UI or not when it is changed it with the custom validity option Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>

Merge pull request #233 from tw-mosip/injiweb-1359-fix-tests

dbab742

[Injiweb 1359] fix failing tests and remove the redundant tests

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Critical code review PR - Last sprint handover checklist of 0.11.0 release #228

Critical code review PR - Last sprint handover checklist of 0.11.0 release #228

vishwa-vyom commented Jan 8, 2025

vishwa-vyom Jan 8, 2025

swatigoel Jan 8, 2025

Gurpreet41082 Jan 9, 2025

vishwa-vyom Jan 8, 2025

swatigoel Jan 8, 2025

Gurpreet41082 Jan 9, 2025

vishwa-vyom Jan 8, 2025

swatigoel Jan 8, 2025

vishwa-vyom Jan 8, 2025

swatigoel Jan 8, 2025

swatigoel Jan 8, 2025

swatigoel Jan 8, 2025

swatigoel Jan 8, 2025

Gurpreet41082 Jan 9, 2025

swatigoel Jan 8, 2025

swatigoel Jan 8, 2025

Gurpreet41082 Jan 9, 2025

swatigoel Jan 8, 2025

swatigoel Jan 8, 2025

swatigoel Jan 8, 2025

PuBHARGAVI Jan 9, 2025

swatigoel Jan 8, 2025

PuBHARGAVI Jan 9, 2025

swatigoel Jan 8, 2025


		## What is in the docker-compose folder?

		1. certs folder holds the p12 file which is being created as part of OIDC client onboarding.

Critical code review PR - Last sprint handover checklist of 0.11.0 release #228

Are you sure you want to change the base?

Critical code review PR - Last sprint handover checklist of 0.11.0 release #228

Conversation

vishwa-vyom commented Jan 8, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment