[Injiweb 1203] get the authorization server endpoint from its well-known endpoint #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PuBHARGAVI
commented
Jan 8, 2025
PuBHARGAVI
commented
- Rather than appending /authorize to the authorization server host url fetch the Authorization server endpoint from the server well-known itself
- Handled the below error scenarios :
- If the required grant_types are not supported by the authorization server then show the error screen
- If the internet is turned off when calling the authorization server well-known endpoint show the error toaster saying service is unavailable.
…own endpoint instead of appending /endpoint to authorizationServer Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…equired grant types and use the predefined list of grant types if server doesn't have grant-types field in wellknown endpoint Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…enario in all languages Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
…not available when calling the authorization server wellknown endpoint Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
| @@ -31,7 +31,7 @@ describe('Testing API Class', () => { | |||
| }); | |||
|
|
|||
| test('Check mimotoHost property', () => { | |||
| expect(apiModule.api.mimotoHost).toBe('https://api.collab.mossip.net/v1/mimoto'); | |||
| expect(apiModule.api.proxyServerHost).toBe('https://api.collab.mossip.net/v1/mimoto'); | |||
There was a problem hiding this comment.
@PuBHARGAVI we dont have now proxy server. is this still hold true?
There was a problem hiding this comment.
changed this back to mimotoHost
…-auth-endpoint-from-wellknown
…the requests from all origins and proxy-server code is removed Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
inji-web/src/utils/api.ts
Outdated
| static fetchTokenAnddownloadVc: ApiRequest = { | ||
| url: () => api.mimotoHost + `/credentials/download`, | ||
| url: () => api.proxyServerHost + `/credentials/download`, |
inji-web-proxy/proxy_server.js
Outdated
There was a problem hiding this comment.
remove this folder from your local now.
…iles Signed-off-by: PuBHARGAVI <46226958+PuBHARGAVI@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.