Merge pull request #4 from msinamsina/3-space-in-path-make-an-error

fix: space in path bug is fixed

src/pytest_pyvenv/__init__.py

@@ -1,5 +1,6 @@
 import os
 import platform
+import shlex
 import subprocess
 import tempfile
 from contextlib import contextmanager
@@ -8,6 +9,7 @@
 from cookiecutter.utils import rmtree
 
 
+
 @contextmanager
 def inside_dir(dirpath):
     """
@@ -38,8 +40,7 @@ def run_inside_dir(command, dirpath):
         Path of the directory the command is being run.
     """
     with inside_dir(dirpath):
-        return subprocess.run(shlex.split(command),
-                              shell=True, executable="/bin/bash")
+        return subprocess.run(shlex.split(command), shell=True)
 
 
 @pytest.fixture
@@ -61,7 +62,9 @@ def __init__(self):
         else:
             raise FileNotFoundError("Python path not found")
         print(f"Python path: {python_path}")
+        python_path = os.path.abspath(python_path)
         self.python_path = python_path.replace(os.sep, "/")
+        venv_dir = os.path.abspath(venv_dir)
         self.env_dir = venv_dir.replace(os.sep, "/")
         if os.name == "nt":
             # Windows
@@ -74,6 +77,8 @@ def __init__(self):
             print(os.listdir(os.path.join(venv_dir, "bin")))
             self.activator = self.activator
 
+        self.activator = f"\"{self.activator}\""
+
     def __del__(self):
         print(f"Deleting virtual environment in {self.env_dir}")
         rmtree(self.env_dir)

tests/my pkg/myapp.py

@@ -0,0 +1 @@
+print('hello world')

tests/my pkg/pyproject.toml

@@ -0,0 +1,12 @@
+[build-system]
+requires = ["setuptools"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "mypkg"
+description = "A package for create venv in tests"
+readme = "README.md"
+version = "0.1.0"
+
+[tool.setuptools]
+py-modules = ['myapp']

tests/test_venv_class.py

@@ -1,6 +1,6 @@
 import pytest
 
-from src.pytest_pyvenv import VenvClass
+from src.pytest_pyvenv import VenvClass, run_inside_dir, inside_dir
 
 
 def test_install_package():
@@ -35,3 +35,39 @@ def test_install_package_with_options():
                                     ["--no-deps"]).returncode == 0
         # check pytest is installed
         assert venv.run("pip show mypkg").returncode == 0
+
+
+def test_space_in_package_path():
+    with VenvClass() as venv:
+        # check mypkg is not installed
+        print(venv.run("mypkg --version").stdout.decode("utf-8"))
+        assert venv.run("mypkg --version").returncode != 0
+        # install mypkg
+        assert venv.install_package("tests/my pkg").returncode == 0
+        # check pytest is installed
+        assert venv.run("pip show mypkg").returncode == 0
+        # check mypkg is installed
+        # uninstall mypkg
+        assert venv.run("pip uninstall -y mypkg").returncode == 0
+        # check mypkg is not installed
+        assert venv.run("mypkg --version").returncode != 0
+
+
+def test_space_in_venv_path():
+    run_inside_dir("mkdir 'my venv'", "./tests")
+    with inside_dir("tests/my venv"):
+        with VenvClass() as venv:
+            print(venv.run("python --version").stderr.decode("utf-8"))
+            assert venv.run("python --version").returncode == 0
+            # check mypkg is not installed
+            print(venv.run("pip show mypkg").stdout.decode("utf-8"))
+            assert venv.run("pip show mypkg").returncode != 0
+            # install mypkg
+            assert venv.install_package("../my pkg").returncode == 0
+            # check pytest is installed
+            assert venv.run("pip show mypkg").returncode == 0
+            # check mypkg is installed
+            # uninstall mypkg
+            assert venv.run("pip uninstall -y mypkg").returncode == 0
+            # check mypkg is not installed
+            assert venv.run("mypkg --version").returncode != 0