Fight with windows

muffinista · Nov 10, 2023 · 113a037 · 113a037
1 parent 95640a4
commit 113a037
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -8,6 +8,7 @@ jobs:
         os: [ubuntu-latest, windows-latest, macos-latest]
     env:
       PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
+      # "$Env:GYP_MSVS_VERSION": 2022
     steps:
     - name: Install ubuntu requirements
       if: ${{ matrix.os == 'ubuntu-latest' }}
@@ -20,11 +21,17 @@ jobs:
       with:
         node-version-file: '.nvmrc'
         cache: 'npm'
-    - name: Patch node-gyp
+    - name: Specify MSVS version
       if: ${{ matrix.os == 'windows-latest' }}
       shell: powershell
       run: |
-        npm config set msvs_version 2022
+        echo "GYP_MSVS_VERSION=2022" >> $env:GITHUB_ENV
+
+    # - name: Patch node-gyp
+    #   if: ${{ matrix.os == 'windows-latest' }}
+    #   shell: powershell
+    #   run: |
+    #     npm config set msvs_version 2022
     - run: npm ci
     - run: npm run test-lib
     - name: Run integration tests

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -20,11 +20,17 @@ jobs:
       uses: actions/setup-node@v3
       with:
         node-version-file: '.nvmrc'
-    - name: Patch node-gyp
+    - name: Specify MSVS version
       if: ${{ matrix.os == 'windows-latest' }}
       shell: powershell
       run: |
-        npm config set msvs_version 2022
+        echo "GYP_MSVS_VERSION=2022" >> $env:GITHUB_ENV
+    
+    # - name: Patch node-gyp
+    #   if: ${{ matrix.os == 'windows-latest' }}
+    #   shell: powershell
+    #   run: |
+    #     npm config set msvs_version 2022
     - run: npm ci
     - name: Release
       env: