Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SolarWinds SSoT Integration #631

Merged
merged 6 commits into from
Jan 9, 2025
Merged

Add SolarWinds SSoT Integration #631

merged 6 commits into from
Jan 9, 2025

Conversation

nopg
Copy link
Contributor

@nopg nopg commented Dec 12, 2024 •
edited
Loading

This PR integrates @jdrew82 's SolarWinds SSoT into the main SSoT.

Minor updates:

  • Location_type is no longer required (if location override is selected)
  • Checks for unnecessary 'extra' Parent location if not needed.
  • Includes most recent SolarWinds PR's:
    • Pull devices from SolarWinds CustomProperty
    • Reprocessing IP/Prefixes to ensure IP has the appropriate Parent Prefix associated.

@nopg nopg requested a review from a team as a code owner December 12, 2024 23:05
@nopg nopg force-pushed the u/nopg/solarwinds-integration branch from 5991283 to 7b7396e Compare December 12, 2024 23:39
@jdrew82 jdrew82 self-assigned this Dec 13, 2024
@jdrew82 jdrew82 added type: major feature integration: solarwinds Issues/PRs for Solarwinds integration. labels Dec 13, 2024
@jdrew82 jdrew82 self-requested a review December 13, 2024 15:34
@jdrew82 jdrew82 removed their assignment Dec 13, 2024
jdrew82
jdrew82 requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things to address.

docs/user/integrations/solarwinds.md Outdated Show resolved Hide resolved
docs/user/integrations/solarwinds.md Outdated Show resolved Hide resolved
docs/user/integrations/solarwinds.md Show resolved Hide resolved
docs/user/integrations/solarwinds.md Outdated Show resolved Hide resolved
jdrew82
jdrew82 requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. One last thing before I think we're good to merge this. We need to update the CODEOWNERS for this integration. Perhaps list you and me?

jdrew82
jdrew82 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jdrew82
jdrew82 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82 jdrew82 merged commit 9248568 into develop Jan 9, 2025
15 checks passed
@jdrew82 jdrew82 deleted the u/nopg/solarwinds-integration branch January 9, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrew82 jdrew82 jdrew82 approved these changes

Assignees

@nopg nopg

Labels
integration: solarwinds Issues/PRs for Solarwinds integration. type: major feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nopg @jdrew82