Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Now Integration - Fixes issue #634 #637

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Service Now Integration - Fixes issue #634 #637

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
466b07f
Fixes issue #634
Dec 17, 2024
187dd48
fix documentation
Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changes/634.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
ServiceNow Integration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rephrase this to be a bit more concise. This is the changelog fragment that will be added to the release notes when we cut the next release. This should be a single line or two at most.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve made the change. I hope it’s better now.

When running the Nautobot ⟹ ServiceNow job with a site filter set, you expect the job to sync only the specified locations to ServiceNow.
However, it appears that the job currently loads only the parent locations, not the specified location itself.
This is fixed by initializing the locations list with the user-selected location and then loading the parent locations of that selection.
2 changes: 1 addition & 1 deletion nautobot_ssot/integrations/servicenow/diffsync/adapter_nautobot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def load_locations(self):
"""Load Nautobot Location objects as DiffSync Location models."""
if self.site_filter is not None:
# Load only direct ancestors of the given Site
locations = []
locations = [self.site_filter]
ancestor = self.site_filter.parent
while ancestor is not None:
locations.insert(0, ancestor)
Expand Down