Fix DNAC SSoT Empty Locations #643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdrew82
added
type: bug
… not found in Location Map.
…e from Device POV instead of loading all. This should ensure that only Locations that have a Device associated will be imported.
… have it used in loading.
…t already in the Floor name.
…g name is in the floor name.
…ent if provided in Job location_map.
…or both building and area locations.
… update with Job location_map.
…date test to use it.
jdrew82
force-pushed
the
patch-635-dna-center-integration-imports-empty-locations-with-meraki-import-disabled
branch
from
fb0bb77 to
fa42e21
Compare
jdrew82
deleted the
patch-635-dna-center-integration-imports-empty-locations-with-meraki-import-disabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes out #635 issue by refactoring how Locations are loaded in. This should ensure that empty Locations are NOT created during a sync.