Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workload cluster packages that avoid package context manipulation #59

Merged

Conversation

johnbelamaric
Copy link
Member

@johnbelamaric johnbelamaric commented Jun 1, 2023

This reduced the flakiness of the cluster creation and package approval process.

@nephio-prow nephio-prow bot requested review from radoslawc and vjayaramrh June 1, 2023 19:34
@johnbelamaric
Copy link
Member Author

johnbelamaric commented Jun 1, 2023

/hold

Wait until nephio-project/nephio-example-packages#42 merges and we tag all the packages before merging this.

@johnbelamaric johnbelamaric changed the title Bump nephio-workload-cluster version Use workload cluster packages that avoid package context manipulation Jun 1, 2023
@johnbelamaric
Copy link
Member Author

Other PR has merged and I tagged those packages.

/hold cancel

@johnbelamaric
Copy link
Member Author

@vjayaramrh @electrocucaracha @henderiw I think this one is the last one that has to merge for the e2e README to work.

@electrocucaracha
Copy link
Member

The e2e check is giving false positives, I'll try to test it locally until the fix is merged, but I think it is ok to approve it

/lgtm

@vishwanathj
Copy link

@vjayaramrh @electrocucaracha @henderiw I think this one is the last one that has to merge for the e2e README to work.

Will take a look and try it out

@radoslawc
Copy link
Collaborator

/approve

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jun 5, 2023
@nephio-prow nephio-prow bot merged commit a66a425 into nephio-project:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants