New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cli bug in high version of tyro #3567

Open

Tavish9 wants to merge 3 commits into nerfstudio-project:main from Tavish9:main

Contributor

Tavish9 commented Jan 10, 2025

In higher version of tyro(>0.9.3), the cli cannot recognize the following config definition:

"""Use the same proposal network. Otherwise use different ones."""
proposal_net_args_list: List[Dict] = field(
    default_factory=lambda: [
        {"hidden_dim": 16, "log2_hashmap_size": 17, "num_levels": 5, "max_res": 128, "use_linear": False},
        {"hidden_dim": 16, "log2_hashmap_size": 17, "num_levels": 5, "max_res": 256, "use_linear": False},
    ]
)

Reproduction:

ns-train nerfacto --pipeline.model.proposal-net-args-list.0.hidden-dim 1

In typo==0.9.2:

In typo>0.9.2:


          limited the tyro version up to 0.9.2

6f03058

brentyi mentioned this pull request

Fix list[dict] regression brentyi/tyro#228

Merged

brentyi added 2 commits

January 10, 2025 01:22


          bump tyro>=0.9.8

ee96e40


          Bump typeguard

65c106c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet