Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Cisco N540X-6Z18G-SYS-D. #2624

Closed
wants to merge 13 commits into from

Conversation

t2ylorgang
Copy link

Added Cisco N540X-6Z18G-SYS-D to device types. As far as the interfaces, I set them up to be 1000BASET and 10BASE X SFP+.

According to this documentation:
https://www.cisco.com/c/en/us/td/docs/iosxr/ncs5xx/hardware/installation/guide/b-ncs540-small-density-routers-hig/m-overview-ncs540-small-density-routers.html#id_75425

"The Cisco N540X-6Z18G-SYS-A/D and N540-6Z18G-SYS-A/D routers have the following network interfaces:

  • 18 x 1G SFP+ ports
  • 6 x 1G/10G SFP+ ports"

My file has the "1G SFP+ ports" as 1000base-t and the "1G/10G SFP+ ports" as 10gbase-x-sfpp

I feel this was the best way to represent a real world application of this router. Obviously, these interface types can change depending on a real world application, but this is a good template IMO.

I can change these to be the predefined SFP ports in Netbox - SFP (1GE) and SFP+ (10GE) if the reviewer thinks this is a better way. Netbox does not have a predefined interface type for a 1/10GE port : (

Erased comments and changed airflow to "right to left"
Added document separator and deleted empty lines.
Copy link
Collaborator

@harryajc harryajc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix the issues detected by the pre-commit checks

description: 'Alarm signaling port.'
interfaces:
- name: GigabitEthernet0/0/0/0
type: 1000base-t
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these 1G SFP ports they need to be modeled using 1000base-x-sfp

@harryajc harryajc added the status: revisions needed This issue requires additional information to be actionable label Jan 10, 2025
@harryajc harryajc marked this pull request as draft January 10, 2025 08:53
@t2ylorgang t2ylorgang closed this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: revisions needed This issue requires additional information to be actionable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants