-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Cisco N540X-6Z18G-SYS-D. #2624
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erased comments and changed airflow to "right to left"
Added document separator and deleted empty lines.
harryajc
requested changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also fix the issues detected by the pre-commit checks
description: 'Alarm signaling port.' | ||
interfaces: | ||
- name: GigabitEthernet0/0/0/0 | ||
type: 1000base-t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For these 1G SFP ports they need to be modeled using 1000base-x-sfp
harryajc
added
the
status: revisions needed
This issue requires additional information to be actionable
label
Jan 10, 2025
Changed interface type to 1000base-x-sfp for the GigabitEthernet ports.
Format fixes.
Deleted to add new fixed file.
Added fixed N540X-6Z18G-SYS-D attempt 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Cisco N540X-6Z18G-SYS-D to device types. As far as the interfaces, I set them up to be 1000BASET and 10BASE X SFP+.
According to this documentation:
https://www.cisco.com/c/en/us/td/docs/iosxr/ncs5xx/hardware/installation/guide/b-ncs540-small-density-routers-hig/m-overview-ncs540-small-density-routers.html#id_75425
"The Cisco N540X-6Z18G-SYS-A/D and N540-6Z18G-SYS-A/D routers have the following network interfaces:
My file has the "1G SFP+ ports" as 1000base-t and the "1G/10G SFP+ ports" as 10gbase-x-sfpp
I feel this was the best way to represent a real world application of this router. Obviously, these interface types can change depending on a real world application, but this is a good template IMO.
I can change these to be the predefined SFP ports in Netbox - SFP (1GE) and SFP+ (10GE) if the reviewer thinks this is a better way. Netbox does not have a predefined interface type for a 1/10GE port : (