fix(RecipeDb): Remove unnecessary is_array() check

Signed-off-by: provokateurin <kate@provokateurin.de>
nextcloud · Jan 4, 2025 · 067f974 · 067f974
1 parent b7df5f8
commit 067f974
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/lib/Db/RecipeDb.php b/lib/Db/RecipeDb.php
@@ -349,7 +349,7 @@ public function getRecipesByKeywords(string $keywords, string $user_id) {
 	 * @throws \OCP\AppFramework\Db\DoesNotExistException if not found
 	 */
 	public function findRecipes(array $keywords, string $user_id) {
-		$has_keywords = $keywords && is_array($keywords) && $keywords[0];
+		$has_keywords = $keywords && $keywords[0];
 
 		if (!$has_keywords) {
 			return $this->findAllRecipes($user_id);

diff --git a/tests/psalm-baseline.xml b/tests/psalm-baseline.xml
@@ -26,12 +26,6 @@
       <code><![CDATA['Recipe ' . $id . ' deleted successfully']]></code>
     </InvalidArgument>
   </file>
-  <file src="lib/Db/RecipeDb.php">
-    <RedundantCondition>
-      <code><![CDATA[$keywords && is_array($keywords)]]></code>
-      <code><![CDATA[is_array($keywords)]]></code>
-    </RedundantCondition>
-  </file>
   <file src="lib/Helper/UserFolderHelper.php">
     <MissingDependency>
       <code><![CDATA[$this->root]]></code>