Feat: Add search message tab to the right sidebar #14125
+614
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorraJaouad
added
enhancement
feature: chat 💬
Antreesy
reviewed
Jan 14, 2025
src/components/RightSidebar/SearchMessages/SearchMessagesTab.vue
Outdated
Show resolved
Hide resolved
src/components/RightSidebar/SearchMessages/SearchMessagesTab.vue
Outdated
Show resolved
Hide resolved
src/components/RightSidebar/SearchMessages/SearchMessagesTab.vue
Outdated
Show resolved
Hide resolved
Antreesy
reviewed
Jan 14, 2025
Signed-off-by: JungleDruid <3953982+JungleDruid@users.noreply.github.com>
Signed-off-by: JungleDruid <3953982+JungleDruid@users.noreply.github.com>
…ional tab Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
… scale instead of time. Change to native component Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
DorraJaouad
force-pushed
the
feat/11130/search-messages
branch
from
e1a4ae8 to
584b53c
Compare
DorraJaouad
changed the title
Antreesy
reviewed
Jan 15, 2025
| :title="t('spreed', 'Back')" | ||
| @click="showSearchMessagesTab = false"> | ||
| <template #icon> | ||
| <IconArrowLeft :size="20" /> |
There was a problem hiding this comment.
nitpick: this would probably look wrong in RTL layout. But we have to reverse all such icons (follow-up)
body[dir="rtl"] .material-design-icon.arrow-left-icon {
transform: scaleX(-1);
}|
|
||
| const token = computed(() => store.getters.getToken()) | ||
| const participantsInitialised = computed(() => store.getters.participantsInitialised(token.value)) | ||
| const participants = computed<UserFilterObject>(() => { |
There was a problem hiding this comment.
Person could have left the conversation.
To fix: filter out guests, circles, groups, e.t.c. - they don't work
Follow-up: use /contactsmenu/contacts endpoint as in UnifiedSearch (require loading callback: https://vue-select.org/api/events.html#search)
Then we could get rid of vuex store usage here
|
|
||
| try { | ||
| cancelSearch.value('canceled') | ||
| const { request, cancel } = CancelableRequest(searchMessages) |
There was a problem hiding this comment.
Atm it's not made correctly, but we could use 'as' for requests. Check NewMessageChatSummary.vue for reference
Suggested change
| const { request, cancel } = CancelableRequest(searchMessages) | |
| type SearchMessageCancelableRequest = { | |
| request: (payload: SearchMessagePayload) => UnifiedSearchResponse, | |
| cancel: () => void, | |
| } | |
| const { request, cancel } = CancelableRequest(searchMessages) as SearchMessageCancelableRequest |
| <template v-if="searchResults.length !== 0"> | ||
| <NcListItem v-for="item of searchResults" | ||
| :key="`message_${item.attributes.messageId}`" | ||
| :data-nav-id="`message_${item.attributes.messageId}`" |
There was a problem hiding this comment.
Follow-up: this need a composable to make arrow navigation work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Recording.2025-01-15.091600.mp4
🚧 Tasks
🏁 Checklist