Fix relation metadata indexing in nidx + old index #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2770 +/- ##
==========================================
- Coverage 86.83% 86.78% -0.05%
==========================================
Files 384 384
Lines 24308 24308
==========================================
- Hits 21107 21096 -11
- Misses 3201 3212 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
carlesonielfa
changed the title
javitonino
approved these changes
Jan 9, 2025
| @@ -65,7 +65,7 @@ pub fn index_relations( | |||
|
|
|||
| if let Some(metadata) = relation.metadata.as_ref() { | |||
| let encoded_metadata = metadata.encode_to_vec(); | |||
| new_doc.add_bytes(schema.label, encoded_metadata); | |||
| new_doc.add_bytes(schema.metadata, encoded_metadata); | |||
| @@ -37,7 +37,7 @@ pub fn index_relations( | |||
| let source = relation.source.as_ref().expect("Missing source"); | |||
| let source_value = source.value.as_str(); | |||
| let source_type = io_maps::node_type_to_u64(source.ntype()); | |||
| let soruce_subtype = source.subtype.as_str(); | |||
| let source_subtype = source.subtype.as_str(); | |||
| assert_eq!(metadata.source_end, Some(10)); | ||
| assert_eq!(metadata.to_start, Some(11)); | ||
| assert_eq!(metadata.to_end, Some(20)); | ||
| assert_eq!(metadata.data_augmentation_task_id, Some("mytask".to_string())); |
There was a problem hiding this comment.
Nice to get a test as a bonus! 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes small bug in nidx and old index that prevented relation metadata from being stored properly
How was this PR tested?