Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extract strategy for text, file and link fields #2774

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

bloodbare
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.03%. Comparing base (f612bd3) to head (1fb4dd8).

Files with missing lines Patch % Lines
nucliadb/src/nucliadb/writer/api/v1/upload.py 60.00% 2 Missing ⚠️
nucliadb/src/nucliadb/writer/resource/field.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2774      +/-   ##
==========================================
- Coverage   87.13%   87.03%   -0.10%     
==========================================
  Files         386      386              
  Lines       24293    24304      +11     
==========================================
- Hits        21167    21153      -14     
- Misses       3126     3151      +25     
Flag Coverage Δ
nucliadb 74.92% <76.92%> (+<0.01%) ⬆️
nucliadb-ingest 40.79% <7.69%> (-0.03%) ⬇️
nucliadb-reader 42.99% <7.69%> (-0.01%) ⬇️
nucliadb-search 43.69% <7.69%> (-0.02%) ⬇️
nucliadb-standalone 47.56% <23.07%> (-0.03%) ⬇️
nucliadb-train 45.74% <23.07%> (-0.02%) ⬇️
nucliadb-writer 46.26% <53.84%> (+<0.01%) ⬆️
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_models 85.81% <100.00%> (-0.01%) ⬇️
nucliadb_sdk 80.11% <ø> (ø)
nucliadb_sidecar 87.24% <ø> (-1.79%) ⬇️
nucliadb_telemetry 86.56% <ø> (ø)
nucliadb_utils 83.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran changed the title Push Options Add extract strategy for text, file and link fields Jan 14, 2025
@lferran lferran marked this pull request as ready for review January 14, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants