Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to replace host for local network #153

Closed
wants to merge 2 commits into from

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Jun 12, 2023

closes #154
Adds functionality to replace the host for local networks. Need to consider how to do this securely can check subnet for ipv4, but ipv6 is a bit trickier.

@vercel
Copy link

vercel bot commented Jun 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fcl-discovery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 2:04am

@@ -271,9 +271,9 @@
"f_type": "Service",
"f_vsn": "1.0.0",
"type": "authn",
"method": "IFRAME/RPC",
"method": "HTTP/POST",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this supposed to be an additional service?

@chasefleming
Copy link
Member

Closing for security concerns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hostname query param mechanic to FCL discovery
2 participants