Fix Windows tests #1555
Merged
Fix Windows tests #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jribbink
force-pushed
the
jribbink/fix-windows-tests
branch
from
8d64cd0 to
54c967c
Compare
jribbink
added
the
Improvement
jribbink
requested review from
Kay-Zee,
janezpodhostnik,
sideninja,
chasefleming,
nvdtf,
bluesign,
bjartek and
ianthpun
as code owners
jribbink
commented
May 2, 2024
| .PHONY: install-linter | ||
| install-linter: | ||
| curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ${GOPATH}/bin v1.47.2 | ||
|
|
||
| .PHONY: lint |
There was a problem hiding this comment.
We don't use this at all anymore, it's part of install-tools
jribbink
force-pushed
the
jribbink/fix-windows-tests
branch
from
4704cd6 to
3778752
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1555 +/- ##
==========================================
+ Coverage 39.70% 39.71% +0.01%
==========================================
Files 51 51
Lines 2944 3278 +334
==========================================
+ Hits 1169 1302 +133
- Misses 1620 1814 +194
- Partials 155 162 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chasefleming
approved these changes
May 2, 2024
ianthpun
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1556
Description
Fixes our long-standing issue with Windows tests doing nothing :P. The CGO fixes we made a while back sovled half the issue, this solves the rest.
Example failing CI here (we used to have the issue that failing Windows tests didn't cause the to fail, this shows that it is fixed):
https://github.com/onflow/flow-cli/actions/runs/8915898654/job/24486335666
For contributor use:
masterbranchFiles changedin the Github PR explorer