Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Samsung Galaxy Tab S6 Lite #200

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

MagicLike
Copy link
Member

Added support for the Samsung Galaxy Tab S6 Lite.

@Vandypants please test the config.

resolves #195

@tsterbak tsterbak added the device Request to add or improve a specific device. label Jul 30, 2023
@tsterbak tsterbak added this to the Release Beta-Version 0.4.5 milestone Jul 30, 2023
@MagicLike MagicLike linked an issue Sep 9, 2023 that may be closed by this pull request
@tsterbak
Copy link
Member

Do you think this is ready and should be included?

@Vandypants
Copy link

I still need to test it. I plan to do it on Friday, and then I can reply. Does that work for you?

@MagicLike
Copy link
Member Author

MagicLike commented Sep 27, 2023

@tsterbak Should I also add device code support for the lte version? - I don't see any significant differences in the lineage wiki

https://wiki.lineageos.org/devices/gta4xlwifi/install

https://wiki.lineageos.org/devices/gta4xl/install

@Vandypants
Copy link

I can't answer that, as I don't have an LTE version I could test with. It's your call, bro.

@tsterbak
Copy link
Member

@tsterbak Should I also add device code support for the lte version? - I don't see any significant differences in the lineage wiki

Since it has different lineageOS versions, I guess both devices should be treated as different, since compatibility checking seems necessary and I don't want people to be able to install the wrong OS version too easily :D

@MagicLike
Copy link
Member Author

@tsterbak Should I also add device code support for the lte version? - I don't see any significant differences in the lineage wiki

Since it has different lineageOS versions, I guess both devices should be treated as different, since compatibility checking seems necessary and I don't want people to be able to install the wrong OS version too easily :D

done!

@Vandypants
Copy link

Sorry for the late reply. I tried the Linux app again and I get the error that "Device with code 'gta4xlwifi' is not supported yet". Here is the info on my tablet...

Software Information:

One Ul version 4.1

Android version 12

Google Play system update January 1, 2022

Kernel version 4.14.113-23851207 #1 Wed Mar 9 18:04:34 KST 2022

Build number SPIA.210812.016.P610XXU2EVC5

SE for Android status
Enforcing
SEPF SM-P610_12_0001 Wed Mar 09 18:20:11 2022

Knox version Knox 3.8

Knox API level 35

Service provider software version SAOMC_SM-P610_OXM_XAC_12_0002 XÁC XÁC

Security software version ASKS v4.5 Release 20211027 ADP v3.0 Release 20191001 SMR Mar 2022 Release 1

Android security patch level March 1, 2022

@tsterbak
Copy link
Member

tsterbak commented Oct 3, 2023

Hi, no worries, thanks for testing.
This PR is not merged, so it is to be expected, that the device doesn't work out of the box.

@Vandypants
Copy link

I will do that now. I'm running Pop!_OS. Which directory do I need to place the gta4xlwifi.yaml file in?

@tsterbak
Copy link
Member

tsterbak commented Oct 3, 2023

I will do that now. I'm running Pop!_OS. Which directory do I need to place the gta4xlwifi.yaml file in?

You should download the respective executable file of the Installer, and then the directory is the directory where the executable is running. For the flatpak this is not easily possible since it is sandboxed.

@Vandypants
Copy link

Got it. I'll switch to a Windows laptop and give it a try.

@Vandypants
Copy link

Now, I need help finding a TWRP recovery image online. All the links show 404 or something like that. Do you have any suggestions, or should I give up? :(

@tsterbak
Copy link
Member

tsterbak commented Oct 3, 2023

[WRONG LINK!] You can find it here: https://twrp.me/xiaomi/xiaomipocox3pro.html

I'll fix the link

@Vandypants
Copy link

Thanks. Now I am getting this error message (taken from Advanced output):

Sheimdall flash --no-reboot --RECOVERY
Heimdall v1.4.0
Copyright (c) 2010-2013, Benjamin Dobell, Glass Echidna >http://www.glassechidna.com.au/
This software is provided free of charge. Copying and redistribution is
encouraged.
If you appreciate this software and you would like to support future > development please consider donating:
http://www.glassechidna.com.au/donate/ >Initialising connection...
Detecting device...
ERROR: Failed to access device. libusb error: -12

@tsterbak
Copy link
Member

tsterbak commented Oct 4, 2023

Yeah, that's quite and annoying issue...
It might indicate, that there are Samsung drivers missing on Windows (https://android.stackexchange.com/questions/98338/heimdall-error-libusb-error-12).
You could try the steps in the post, or try it on Linux. I guess the Debianbased executables would also run on pop_OS 🤔

@anon1892
Copy link
Member

anon1892 commented Oct 4, 2023

You can find it here: https://twrp.me/xiaomi/xiaomipocox3pro.html

Wrong device, isn't it?

@MagicLike
Copy link
Member Author

I guess the Debian based executables would also run on pop_OS 🤔

Yup, it should, as pop_OS is based on Ubuntu

@tsterbak
Copy link
Member

tsterbak commented Oct 4, 2023

Wrong device, isn't it?

Öhm, well yes 😬 Wrong issue...

The official TWRP link for the Samsung Galaxy Tab S6 Lite seems to be gone...

It seems to be discontinued because of softbricking issues with OTA... https://forum.xda-developers.com/t/closed-discontinued-recovery-official-twrp-for-galaxy-tab-s6-lite.4166985/page-4

@MagicLike

This comment was marked as off-topic.

@tsterbak

This comment was marked as resolved.

@MagicLike

This comment was marked as resolved.

@MagicLike MagicLike added the needs testing Device support was added, but it still needs testing label Oct 8, 2023
@MagicLike
Copy link
Member Author

Any news from your side @Vandypants?

@Vandypants
Copy link

I did download and install the Windows drivers and still got the same error message. I'm away from home for another 48 hours. When I do get back home, I will switch to Ubuntu and try it again.

@MagicLike MagicLike added the hacktoberfest-accepted PR accepted for Hacktoberfest label Oct 12, 2023
@Vandypants
Copy link

I've been sick for the last few days. I have yet to be able to get Ubuntu on my system, so I can't test that your updates worked. Sorry.

@tsterbak
Copy link
Member

I've been sick for the last few days. I have yet to be able to get Ubuntu on my system, so I can't test that your updates worked. Sorry.

No worries, I hope you are better now :) Looking forward to hear from you

@tsterbak tsterbak removed this from the Release Beta-Version 0.5.1 milestone Oct 29, 2023
@MagicLike
Copy link
Member Author

@Vandypants Any updates regarding testing? 👀

@Vandypants
Copy link

No change. Your app says that the tablet is unsupported.

@tsterbak
Copy link
Member

The device is still not supported by default. You still have to manually place the config yaml for the device.

Did you follow #200 (comment) ?

@MagicLike
Copy link
Member Author

The device is still not supported by default. You still have to manually place the config yaml for the device.

Did you follow #200 (comment) ?

Should I then mark it as untested and we merge it?

@tsterbak
Copy link
Member

Should I then mark it as untested and we merge it?

We could do it I guess. I'm still not aware there is a working TWRP atm 🤔

@MagicLike
Copy link
Member Author

Should I then mark it as untested and we merge it?

We could do it I guess. I'm still not aware there is a working TWRP atm 🤔

Good catch - then I will leave it as-is rn and come back if I have more time to research if it exists. If not, I will add a note to the config and push it here with the untested flag...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
device Request to add or improve a specific device. hacktoberfest-accepted PR accepted for Hacktoberfest needs testing Device support was added, but it still needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for gta4xlwifi
4 participants