Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update Dependencies #642

Draft
wants to merge 10 commits into
base: dev
Choose a base branch
from
Draft

Conversation

SirRGB
Copy link
Contributor

@SirRGB SirRGB commented Nov 23, 2024

grafik
Im kinda stuck here. Picking a correct or incorrect rom has no effect on this screen.

poetry run python openandroidinstaller/openandroidinstaller.py
package:media_kit_libs_linux registered.
2024-11-23 17:16:53.319 | INFO     | __main__:main:218 - Running OpenAndroidInstaller version '0.5.4-beta' on 'linux'.
2024-11-23 17:16:53.326 | INFO     | __main__:log_version_infos:200 - Android Debug Bridge version 1.0.41
2024-11-23 17:16:53.331 | INFO     | __main__:log_version_infos:206 - fastboot version 35.0.1-11580240
2024-11-23 17:16:53.335 | INFO     | __main__:log_version_infos:212 - Heimdall version: Heimdall v1.4.2
2024-11-23 17:16:53.336 | INFO     | __main__:main:220 - ----------------------------------------------------------------------------------------------------
/home/sirrgb/Downloads/git/openandroidinstaller/openandroidinstaller/openandroidinstaller.py:184: DeprecationWarning: window_height is deprecated in version 0.23.0 and will be removed in version 0.26.0. Use Page.window.height instead.
  page.window_height = 900
/home/sirrgb/Downloads/git/openandroidinstaller/openandroidinstaller/openandroidinstaller.py:185: DeprecationWarning: window_height is deprecated in version 0.23.0 and will be removed in version 0.26.0. Use Page.window.height instead.
  page.window_width = int(1.5 * page.window_height)
/home/sirrgb/Downloads/git/openandroidinstaller/openandroidinstaller/openandroidinstaller.py:185: DeprecationWarning: window_width is deprecated in version 0.23.0 and will be removed in version 0.26.0. Use Page.window.width instead.
  page.window_width = int(1.5 * page.window_height)
/home/sirrgb/Downloads/git/openandroidinstaller/openandroidinstaller/openandroidinstaller.py:186: DeprecationWarning: window_top is deprecated in version 0.23.0 and will be removed in version 0.26.0. Use Page.window.top instead.
  page.window_top = 100
/home/sirrgb/Downloads/git/openandroidinstaller/openandroidinstaller/openandroidinstaller.py:187: DeprecationWarning: window_left is deprecated in version 0.23.0 and will be removed in version 0.26.0. Use Page.window.left instead.
  page.window_left = 120
/home/sirrgb/Downloads/git/openandroidinstaller/openandroidinstaller/openandroidinstaller.py:190: DeprecationWarning: window_min_width is deprecated in version 0.23.0 and will be removed in version 0.26.0. Use Page.window.min_width instead.
  page.window_min_width = 1000
/home/sirrgb/Downloads/git/openandroidinstaller/openandroidinstaller/openandroidinstaller.py:191: DeprecationWarning: window_min_height is deprecated in version 0.23.0 and will be removed in version 0.26.0. Use Page.window.min_height instead.
  page.window_min_height = 600
/home/sirrgb/Downloads/git/openandroidinstaller/openandroidinstaller/openandroidinstaller.py:278: DeprecationWarning: banner is deprecated in version 0.23.0 and will be removed in version 0.26.0. Use Page.overlay.append(banner) instead.
  page.banner = Banner(
/home/sirrgb/Downloads/git/openandroidinstaller/openandroidinstaller/openandroidinstaller.py:66: DeprecationWarning: UserControl is deprecated since version 0.21.0 and will be removed in version 0.26.0. UserControl is deprecated. See https://flet.dev/docs/getting-started/custom-controls.
  super().__init__()
2024-11-23 17:16:55.855 | INFO     | __main__:to_next_view:175 - Confirmed and moved to next step.
2024-11-23 17:16:57.019 | INFO     | tooling:search_device:598 - Search devices on linux with /home/sirrgb/Downloads/git/openandroidinstaller/openandroidinstaller/bin...
2024-11-23 17:16:57.094 | INFO     | tooling:search_device:635 - Found device code 'cedric'
2024-11-23 17:16:57.132 | INFO     | installer_config:_find_config_file:108 - Device code 'cedric' is supported by config '/home/sirrgb/Downloads/git/openandroidinstaller/openandroidinstaller/assets/configs/cedric.yaml'.
2024-11-23 17:16:57.139 | SUCCESS  | installer_config:validate_config:190 - Config is valid.
2024-11-23 17:16:57.140 | INFO     | installer_config:_load_config:136 - Loaded device config from /home/sirrgb/Downloads/git/openandroidinstaller/openandroidinstaller/assets/configs/cedric.yaml.
2024-11-23 17:16:57.140 | INFO     | installer_config:_load_config:138 - Config metadata: {'maintainer': 'Tobias Sterbak (tsterbak)', 'device_name': 'Motorola Moto G5', 'is_ab_device': False, 'device_code': 'cedric', 'supported_device_codes': ['cedric']}.
2024-11-23 17:16:58.025 | INFO     | app_state:toggle_flash_unlock_bootloader:86 - Skipping bootloader unlocking.
2024-11-23 17:16:58.887 | INFO     | app_state:toggle_flash_recovery:113 - Skipping flashing recovery.
2024-11-23 17:17:00.304 | INFO     | __main__:to_next_view:175 - Confirmed and moved to next step.
2024-11-23 17:17:04.078 | INFO     | views.requirements_view:enable_continue_button:306 - All requirements ticked. Allow to continue
2024-11-23 17:17:04.886 | INFO     | __main__:to_next_view:175 - Confirmed and moved to next step.
2024-11-23 17:17:04.886 | INFO     | utils:get_download_link:47 - Checking https://download.lineageos.org/api/v2/devices/cedric
2024-11-23 17:17:05.189 | INFO     | utils:get_download_link:56 - https://download.lineageos.org/api/v2/devices/cedric doesn't exist, status_code: 400

@SirRGB SirRGB force-pushed the dev branch 2 times, most recently from 346526e to 1515bfc Compare November 23, 2024 16:45
@tsterbak
Copy link
Member

Looks similar to issue #591.
I was not able to reproduce it so far.

@tsterbak tsterbak added the enhancement New feature or request label Nov 23, 2024
@SirRGB
Copy link
Contributor Author

SirRGB commented Nov 23, 2024

Well I can pick a file in the file picker, but openandroidinstaller doesnt seem to pick it up.

Edit: tried the 0.5.3 beta flatpak again and it works
seems to be unrelated to the issue you mentioned, but might be due to the updated dependencies?

@tsterbak
Copy link
Member

Maybe the behavior of the file picker (events) changed with the new flet version? 🤔

* fixes OSError: [Errno 39] Directory not empty: 'openandroidinstaller/tools/platform-tools' -> 'openandroidinstaller/openandroidinstaller/bin'
  when repeatadly running 'make install'

Signed-off-by: SirRGB <sirrgb@proton.me>
Signed-off-by: SirRGB <sirrgb@proton.me>
Signed-off-by: SirRGB <sirrgb@proton.me>
Signed-off-by: SirRGB <sirrgb@proton.me>
@SirRGB SirRGB force-pushed the dev branch 5 times, most recently from 3c89893 to 3e4ace8 Compare December 7, 2024 19:40
* fixes the following error when running 'make test'
* dont ask me why it works

FAILED tests/test_app.py::test_app_sargo - TypeError: Page.__init__() missing 1 required positional argument: 'loop'
FAILED tests/test_app.py::test_app_beyond2lte - TypeError: Page.__init__() missing 1 required positional argument: 'loop'

Signed-off-by: SirRGB <sirrgb@proton.me>
* rename CountinuosRectangleBorder to ContinuousRectangleBorder as of: flet-dev/website#147
* allows building on [A-Z]ubuntu 24.04
* remove hard-coded python verson in pre commit hooks and update their versions
* add poetry export plugin to address the following warning (still shows up)

Warning: poetry-plugin-export will not be installed by default in a future version of Poetry.
In order to avoid a breaking change and make your automation forward-compatible, please install poetry-plugin-export explicitly. See https://python-poetry.org/docs/plugins/#using-plugins for details on how to install a plugin.
To disable this warning run 'poetry config warnings.export false'.

Signed-off-by: SirRGB <sirrgb@proton.me>
@SirRGB SirRGB changed the title DNM: Update Dependencies WIP: Update Dependencies Dec 10, 2024
@tsterbak tsterbak self-requested a review December 26, 2024 09:23
@tsterbak
Copy link
Member

tsterbak commented Dec 26, 2024

The latest docs of flet state "In Linux, the FilePicker control depends on Zenity when running Flet as an app. This is not a requirement when running Flet in a browser." (https://flet.dev/docs/controls/filepicker)

Not sure if this was a requirement before. Could this be the issue with the filepicker?

@tsterbak
Copy link
Member

Another thing I can think of: Could you try claiming you need to install a recovery? Maybe something in the control flow goes wrong there? 🤔

@SirRGB
Copy link
Contributor Author

SirRGB commented Dec 26, 2024

Iirc Ive tried picking a recovery too, but I assume Zenity is what makes the filepicker fail, I kinda overlooked that, Ill try later today.
Btw do you know why adding the loop argument fixes the tests? I think Ive also tried the values 0 and 2 and it always just worked? I have no clue what it does...

@tsterbak
Copy link
Member

Btw do you know why adding the loop argument fixes the tests? I think Ive also tried the values 0 and 2 and it always just worked? I have no clue what it does...

I have no idea 😅 it looks like something new in flet. Having it at 1 for now should be fine :)

@SirRGB
Copy link
Contributor Author

SirRGB commented Jan 2, 2025

Yea, tried to install zenity on the host machine and added it as dependency, manually imported it, just to be sure, yet no success so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants