Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port retry and client validation changes #155

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

ewanharris
Copy link
Member

Description

Ports changes over relating to the default max retries limit and client validation

References

openfga/sdk-generator#457
openfga/sdk-generator#420

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested review from a team as code owners December 17, 2024 14:49
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.92%. Comparing base (1c690e8) to head (71805f0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   68.79%   68.92%   +0.12%     
==========================================
  Files         124      124              
  Lines        9929     9853      -76     
==========================================
- Hits         6831     6791      -40     
+ Misses       3098     3062      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewanharris ewanharris added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 99f45c7 Dec 17, 2024
17 checks passed
@ewanharris ewanharris deleted the chore/port-changes branch December 17, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants