Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dotnet): export opentelemetry metrics #398

Merged
merged 12 commits into from
Nov 26, 2024
Merged

feat(dotnet): export opentelemetry metrics #398

merged 12 commits into from
Nov 26, 2024

Conversation

rhamzeh
Copy link
Member

@rhamzeh rhamzeh commented Jul 23, 2024

Description

Adds initial OpenTelemetry metrics to the .NET SDK

References

Generates: openfga/dotnet-sdk#69

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@rhamzeh rhamzeh marked this pull request as ready for review July 30, 2024 13:08
@rhamzeh rhamzeh requested a review from a team as a code owner July 30, 2024 13:08
@rhamzeh rhamzeh force-pushed the feat/dotnet-telemetry-metrics branch 2 times, most recently from 0fcb161 to cae5eb9 Compare July 30, 2024 18:55
evansims
evansims previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewanharris ewanharris force-pushed the feat/dotnet-telemetry-metrics branch from cae5eb9 to fbbe656 Compare November 5, 2024 09:48
@ewanharris ewanharris force-pushed the feat/dotnet-telemetry-metrics branch 2 times, most recently from fdf4bab to fe65053 Compare November 15, 2024 12:27
@ewanharris ewanharris requested a review from evansims November 15, 2024 18:03
rhamzeh and others added 12 commits November 18, 2024 15:35
@rhamzeh @ewanharris
feat(dotnet): add support for exporting otel metrics
03a83f5
@rhamzeh @ewanharris
fix(dotnet): drop deprecated otel metrics
16134a5 
Note: These metrics have never been released in the .NET SDK
@rhamzeh @ewanharris
fix(dotnet): switch fga-client.request.method in metrics to TitleCase
03bb65d 
This makes it consistent with Proto naming
@rhamzeh @ewanharris
chore(dotnet): convert attribute interface from KeyValue Pair List to…
43101e7 
… TagList
@rhamzeh @ewanharris
feat(dotnet): properly support exporting user and model id metrics
ffde060
@rhamzeh @ewanharris
fix(dotnet): set token exchange content type as "application/x-www-fo…
9ad57f0 
…rm-urlencode"
@rhamzeh @ewanharris
fix(dotnet): http.request.resend_count metric no longer counts orig…
5564e5a 
…inal request
@rhamzeh @ewanharris
chore(dotnet): use JsonDocument to parse body for attributes in metrics
6373183
@rhamzeh @ewanharris
chore(dotnet): drop client and server request durations from attributes
d2641d6 
Considering that we already have histograms for them, and the const impact of
having attributes with high variance, we're dropping the following two
attributes:
- `http.client.request.duration`
- `http.server.request.duration`
@rhamzeh @ewanharris
release(dotnet): v0.5.1
5fbcdf0
@ewanharris
chore(dotnet-sdk): sync latest telemetry work back
8ebbe03
@ewanharris
chore(dotnet-sdk): sync dependency updates
5347626
@ewanharris ewanharris force-pushed the feat/dotnet-telemetry-metrics branch from fe65053 to 5347626 Compare November 18, 2024 21:36
@rhamzeh
Copy link
Member Author

rhamzeh commented Nov 22, 2024

@evansims @jimmyjames I can't approve this PR, would either of you mind giving it a look?

@ewanharris ewanharris enabled auto-merge November 25, 2024 16:06
@ewanharris ewanharris added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 3661919 Nov 26, 2024
14 checks passed
@ewanharris ewanharris deleted the feat/dotnet-telemetry-metrics branch November 26, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hawxy Hawxy Hawxy left review comments

@jimmyjames jimmyjames jimmyjames approved these changes

@evansims evansims Awaiting requested review from evansims

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rhamzeh @evansims @jimmyjames @Hawxy @ewanharris