Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Python fixes #446

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Minor Python fixes #446

merged 3 commits into from
Nov 7, 2024

Conversation

ewanharris
Copy link
Member

@ewanharris ewanharris commented Nov 5, 2024

Description

This PR fixes some minor issues I noticed while updating the openfga/api sha on `main. Splitting out to a separate PR to help review.

They are as follows:

  • the ListUsers API differs on the shape of contextual_tuples, rather than an object with a tuple_keys property it just takes the array directly. So we don't need the ContextualTupleKeys type
  • read_latest_authorization_model errors if there are no models
  • list_users in the example was using the wrong types

References

openfga/python-sdk#147

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)
It differs from other endpoints in that it isn't an object but just an array directly

@ewanharris ewanharris requested a review from a team as a code owner November 5, 2024 17:31
@ewanharris ewanharris mentioned this pull request Nov 5, 2024
4 tasks
jimmyjames
jimmyjames previously approved these changes Nov 5, 2024
@ewanharris ewanharris added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit aeff213 Nov 7, 2024
14 checks passed
@ewanharris ewanharris deleted the fix/python-minor-fixes branch November 7, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants