Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(python-sdk): remove Optional typings #451

Merged
merged 1 commit into from
Nov 7, 2024
Merged

chore(python-sdk): remove Optional typings #451

merged 1 commit into from
Nov 7, 2024

Conversation

evansims
Copy link
Member

@evansims evansims commented Nov 7, 2024 •
edited
Loading

Description

This PR removes the Optional type hinter, as guidance for Python 3.10+ and PEP 604's introduction is to phase it out in favor of a simple None union type. Note that these are functionally identical and do not affect the method signature for existing integrations.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)

@evansims evansims added the python-sdk Affects the Python SDK label Nov 7, 2024
@evansims evansims mentioned this pull request Nov 7, 2024
Merged
4 tasks
@evansims evansims marked this pull request as ready for review November 7, 2024 05:44
@evansims evansims requested a review from a team as a code owner November 7, 2024 05:44
@evansims evansims enabled auto-merge November 7, 2024 05:45
@evansims evansims added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit a7ac700 Nov 7, 2024
14 checks passed
@evansims evansims deleted the refactor/python-sdk/remove-optional-typings branch November 7, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
python-sdk Affects the Python SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evansims @ewanharris