-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add level icons to log viewer #2968
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Chris Jackson <chris@cd-jackson.com>
#2702 Bundle Size — 10.98MiB (~+0.01%).e6e56b2(current) vs 7ef5b6f main#2698(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
Current #2702 |
Baseline #2698 |
|
---|---|---|
Initial JS | 1.9MiB |
1.9MiB |
Initial CSS | 577.21KiB |
577.21KiB |
Cache Invalidation | 17.39% |
17.51% |
Chunks | 227 |
227 |
Assets | 250 |
250 |
Modules | 2951 |
2951 |
Duplicate Modules | 154 |
154 |
Duplicate Code | 1.8% |
1.8% |
Packages | 98 |
98 |
Duplicate Packages | 2 |
2 |
Bundle size by type 2 changes
2 regressions
Current #2702 |
Baseline #2698 |
|
---|---|---|
JS | 9.19MiB (~+0.01% ) |
9.19MiB |
CSS | 867.06KiB (~+0.01% ) |
867.02KiB |
Fonts | 526.1KiB |
526.1KiB |
Media | 295.6KiB |
295.6KiB |
IMG | 140.74KiB |
140.74KiB |
HTML | 1.38KiB |
1.38KiB |
Other | 871B |
871B |
Bundle analysis report Branch cdjackson:logviewer-levelicon Project dashboard
Generated by RelativeCI Documentation Report issue
I tried the ant icon for debug - that was my first thought, but it looked kinda messy when there's a page full of them. |
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
My only concern, and it's tiny and can be ignored, is that the three horizontal lines usually indicates a "hamburger" menu. Using it in this case shouldn't be confusing, but it's a possibility. |
Following a discussion on the forum where it was pointed out that the colour coding of the log levels was not suitable for colour blind people, I propose to add an icon representing the log level.
The icon is right at the beginning of the line so that it remains in view if the log is scrolled to the right.
I'm open to other icons or thoughts on this...