Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add level icons to log viewer #2968

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cdjackson
Copy link
Contributor

Following a discussion on the forum where it was pointed out that the colour coding of the log levels was not suitable for colour blind people, I propose to add an icon representing the log level.

image

The icon is right at the beginning of the line so that it remains in view if the log is scrolled to the right.

I'm open to other icons or thoughts on this...

Signed-off-by: Chris Jackson <chris@cd-jackson.com>
Copy link

relativeci bot commented Jan 2, 2025

#2702 Bundle Size — 10.98MiB (~+0.01%).

e6e56b2(current) vs 7ef5b6f main#2698(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2702
     Baseline
#2698
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 17.39% 17.51%
No change  Chunks 227 227
No change  Assets 250 250
No change  Modules 2951 2951
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.8% 1.8%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#2702
     Baseline
#2698
Regression  JS 9.19MiB (~+0.01%) 9.19MiB
Regression  CSS 867.06KiB (~+0.01%) 867.02KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch cdjackson:logviewer-leveliconProject dashboard


Generated by RelativeCIDocumentationReport issue

@ghys
Copy link
Member

ghys commented Jan 2, 2025

I think I would do
image
for warnings (instead of the flag)
and still keep the filled
image
for errors.

Perhaps also
image
for debug (not completely sure, I don't really like it) and
image
for trace.

@cdjackson
Copy link
Contributor Author

I tried the ant icon for debug - that was my first thought, but it looked kinda messy when there's a page full of them.

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jan 7, 2025
Signed-off-by: Florian Hotze <dev@florianhotze.com>
@florian-h05
Copy link
Contributor

I chose to try it with the ant and line_horizontal_3 for trace and I think it looks good:

image

Even a page full of debug looks okay IMO.

I have pushed these two icon changes, if you are fine with them please let me know and we can merge.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
@rkoshak
Copy link

rkoshak commented Jan 13, 2025

My only concern, and it's tiny and can be ignored, is that the three horizontal lines usually indicates a "hamburger" menu. Using it in this case shouldn't be confusing, but it's a possibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants