Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Input: Prevent user from adding a semantic tag #2983

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 5, 2025

When the tag input is supposed to filter out semantic tags, also prevent user from entering them.

It is up to the caller of tag-input form to determine whether it can accept semantic tags or not, by specifying it in the showSemanticTags property.

image

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Copy link

relativeci bot commented Jan 5, 2025

#2650 Bundle Size — 10.97MiB (~+0.01%).

26dc94a(current) vs 7ac9838 main#2645(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2650
     Baseline
#2645
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 18.34% 17.34%
No change  Chunks 227 227
No change  Assets 250 250
No change  Modules 2950 2950
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.78% 1.78%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2650
     Baseline
#2645
Regression  JS 9.19MiB (~+0.01%) 9.18MiB
No change  CSS 866.3KiB 866.3KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch jimtng:taginput-semanticsProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks - this is really helpful!

@florian-h05 florian-h05 merged commit 5cba1d8 into openhab:main Jan 7, 2025
5 checks passed
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jan 7, 2025
@florian-h05 florian-h05 added this to the 5.0 milestone Jan 7, 2025
@jimtng jimtng deleted the taginput-semantics branch January 8, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants