Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons Store: Search the add-on id and show search term before loading addons #3015

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 13, 2025

This is a refinement of #3003.

I noticed that when the Thing-Details shows HANDLER_MISSING_ERROR and I clicked Install Binding, it takes me to the Addons Store loading page while it's trying to load the list of addons from the server.

During this time, the search bar is visible, but blank.

This PR sets the search term (i.e. the Binding name) in the search bar to be displayed whilst the list of addons is being loaded, to give the user quicker feedback of what's going on.

This PR consists of 2 commits that probably should be kept separate. The second commit makes the search match the addon id, so that when Install Binding looks for amazonechocontrol it would find it. Previously, it only searched the addon title which is "Amazon Echo Control", so it wouldn't have been found.

The same goes for when user searches for jsscripting, currently this wouldn't have shown a result. This PR fixes that.

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Copy link

relativeci bot commented Jan 13, 2025

#2709 Bundle Size — 10.98MiB (~+0.01%).

daccd7b(current) vs 7ef5b6f main#2698(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2709
     Baseline
#2698
Regression  Initial JS 1.9MiB(~+0.01%) 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 17.54% 17.51%
No change  Chunks 227 227
No change  Assets 250 250
No change  Modules 2951 2951
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.8% 1.8%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2709
     Baseline
#2698
Regression  JS 9.19MiB (~+0.01%) 9.19MiB
No change  CSS 867.02KiB 867.02KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch jimtng:handler-missing-searchProject dashboard


Generated by RelativeCIDocumentationReport issue

@jimtng jimtng changed the title Addons Store: Show search term before loading addons Addons Store: Search the add-on id and show search term before loading addons Jan 14, 2025
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng force-pushed the handler-missing-search branch from b7e5d6b to daccd7b Compare January 14, 2025 01:49
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 merged commit 162aaa6 into openhab:main Jan 14, 2025
5 checks passed
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jan 14, 2025
@florian-h05 florian-h05 added this to the 5.0 milestone Jan 14, 2025
@jimtng jimtng deleted the handler-missing-search branch January 14, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants