Addons Store: Search the add-on id and show search term before loading addons #3015
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refinement of #3003.
I noticed that when the Thing-Details shows
HANDLER_MISSING_ERROR
and I clickedInstall Binding
, it takes me to the Addons Store loading page while it's trying to load the list of addons from the server.During this time, the search bar is visible, but blank.
This PR sets the search term (i.e. the Binding name) in the search bar to be displayed whilst the list of addons is being loaded, to give the user quicker feedback of what's going on.
This PR consists of 2 commits that probably should be kept separate. The second commit makes the search match the addon id, so that when
Install Binding
looks foramazonechocontrol
it would find it. Previously, it only searched the addon title which is "Amazon Echo Control", so it wouldn't have been found.The same goes for when user searches for
jsscripting
, currently this wouldn't have shown a result. This PR fixes that.