Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3-backup: Add optional --remove argument, passed through to mc mirror #223

Merged
merged 1 commit into from
Dec 20, 2024
Merged

s3-backup: Add optional --remove argument, passed through to mc mirror #223

merged 1 commit into from
Dec 20, 2024
+24 −7

Conversation

jthiltges
Copy link
Contributor

No description provided.

matyasselmeci
matyasselmeci approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@matyasselmeci matyasselmeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would it be useful to add a way to pass --dry-run too?

@matyasselmeci matyasselmeci merged commit 184b60d into opensciencegrid:main Dec 20, 2024
5 checks passed
@jthiltges jthiltges deleted the pr/s3-backup-remove branch January 2, 2025 14:09
@jthiltges jthiltges mentioned this pull request Jan 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyasselmeci matyasselmeci matyasselmeci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jthiltges @matyasselmeci